Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate QuickGraph to QuikGraph and GraphSharp to GraphShape. #91

Merged
merged 2 commits into from
Jun 7, 2020

Conversation

KeRNeLith
Copy link
Contributor

Hello,

I updated the quite old QuickGraph and GraphSharp dependencies to respectively QuikGraph and GraphShape.

Those libraries are using modern C# development workflow, have been ported to .NET Core with a wider support in term of targets.
And finally they come with a huge set of unit tests that has helped to debug and fix a lot of issues in both libraries. Some issues were encountered in this project and are now fixed.

Here are the links to both libraries:

@haacked
Copy link
Owner

haacked commented Jun 5, 2020

Thanks! I got the following compilation errors when I tried to compile this PR.

---- Build started: Project: SeeGitApp, Configuration: Debug Any CPU ------
1>C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\MSBuild\Current\Bin\Microsoft.Common.CurrentVersion.targets(2081,5): warning MSB3245: Could not resolve this reference. Could not locate the assembly "Microsoft.Expression.Interactions". Check to make sure the assembly exists on disk. If this reference is required by your code, you may get compilation errors.
1>C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\MSBuild\Current\Bin\Microsoft.Common.CurrentVersion.targets(2081,5): warning MSB3245: Could not resolve this reference. Could not locate the assembly "System.Windows.Interactivity". Check to make sure the assembly exists on disk. If this reference is required by your code, you may get compilation errors.
1>Z:\dev\haacked\seegit\SeeGitApp\Views\CommitVertexView.xaml(23,10): error MC3074: The tag 'Interaction.Behaviors' does not exist in XML namespace 'http://schemas.microsoft.com/expression/2010/interactivity'. Line 23 Position 10.
2>------ Build started: Project: UnitTests, Configuration: Debug Any CPU ------
2>CSC : error CS0006: Metadata file 'Z:\dev\haacked\seegit\SeeGitApp\bin\Debug\SeeGit.exe' could not be found
========== Build: 0 succeeded, 2 failed, 0 up-to-date, 0 skipped ==========

@KeRNeLith
Copy link
Contributor Author

KeRNeLith commented Jun 7, 2020

Update to latest version with strong named assemblies.

On my side building the solution performs well. I'm using Visual Studio 2019 (16.5.4) without any issue.

1>------ Rebuild All started: Project: SeeGitApp, Configuration: Debug Any CPU ------
1>  SeeGitApp -> H:\Documents\Git\SeeGit\SeeGitApp\bin\Debug\SeeGit.exe
2>------ Rebuild All started: Project: UnitTests, Configuration: Debug Any CPU ------
2>  UnitTests -> H:\Documents\Git\SeeGit\UnitTests\bin\Debug\UnitTests.dll
========== Rebuild All: 2 succeeded, 0 failed, 0 skipped ==========

I fully clean temporaries folders prior to build again.

Such error seems related to the System.Windows.Interactivity reference. There is a new way to properly reference the behaviors and it's done by package rather than reference like this.
I already had similar issue in projects directly referencing the System.Windows.Interactivity.

@haacked haacked merged commit b17c87d into haacked:master Jun 7, 2020
@haacked
Copy link
Owner

haacked commented Jun 7, 2020

Thanks! I updated the code to reference the behaviors using a package and it worked for me.

@haacked
Copy link
Owner

haacked commented Jun 7, 2020

687474703a2f2f692e696d6775722e636f6d2f4462433072526c2e676966

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants