Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include a SVG favicon #2554

Closed
1 of 3 tasks
coliff opened this issue Jun 28, 2021 · 0 comments · Fixed by #2622
Closed
1 of 3 tasks

Include a SVG favicon #2554

coliff opened this issue Jun 28, 2021 · 0 comments · Fixed by #2622
Assignees
Milestone

Comments

@coliff
Copy link
Member

coliff commented Jun 28, 2021

I'm submitting a ...

  • bug report
  • feature request
  • other (Please do not submit support requests here (below))

I think we should add a SVG favicon to the root of the project. SVG favicons are supported by all major browsers. As they are scalable vectors they typically have a smaller file size than a larger 24-bit PNG and can support dark mode via a media query.

This is a great post: https://evilmartians.com/chronicles/how-to-favicon-in-2021-six-files-that-fit-most-needs
and I agree with the conclusion that all you need is:

<link rel="icon" href="/favicon.ico"><!-- 32×32 -->
<link rel="icon" href="/icon.svg" type="image/svg+xml">
<link rel="apple-touch-icon" href="/apple-touch-icon.png"><!-- 180×180 -->
<link rel="manifest" href="/site.webmanifest">
@roblarsen roblarsen added this to the v9.0.0 milestone Aug 16, 2021
@coliff coliff self-assigned this Oct 27, 2021
coliff added a commit that referenced this issue Oct 27, 2021
@coliff coliff mentioned this issue Oct 27, 2021
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants