Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cyclic dependency in setup.py #16

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

Darel13712
Copy link

@Darel13712 Darel13712 commented Apr 8, 2020

Hello I came here because I have a problem using poetry add with a package that depends on typesentry. Read details here.

It turned out that there were 2 problems:

  1. typesentry has itself in install_requires which is easy to fix.
  2. __version__ is loaded in a way that triggers __init__ which depends on colorama package which is not available at the time of installation. i.e. pip install . is not working in a clear env, because you have to have colorama for it to work. This is not how it is supposed to be.

I changed the way version is loaded into setup.py so that __init__.py is not triggered, using guidelines from here. You may want to use different approach, but this was my take on it, I think it was the easiest one.

Hope this will solve this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant