Handle thread stream generate exceptions. #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…angs unless don't block or timeout. We choose to not block, and keep checking on status, and communicate from other thread to stream in main thread when it should stop if exception hit.
pseudotensor
force-pushed
the
handlethreadstreamexceptions
branch
from
717049f to
c789569
Compare
…r each so can cancel. But cancel is still imperfect. It still generates on GPU in background, and sometimes shows last result instead of new as if async job was not cancelled but just paused.
both systems pass |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If generate fails, stream hangs unless don't block or timeout. We choose to not block, and keep checking on status, and communicate from other thread to stream in main thread when it should stop if exception hit.