-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Complete mbedtls backend coding #519
Conversation
The last failure is in the linker:
The diagnostic The error only happens after we tried to use errno, so maybe removing that will solve the issue. |
@kazuho This is finally ready. I am sorry for the mess yesterday. I was down with a fever, trying to make it work and missing basic stuff. The latest fix was to add a final NULL byte to the returned buffer -- just copying the content of the file was not enough. Overall, a very small fix, and very contained. |
@kazuho Since this PR was not checked in, I am adding the missing pieces to fully support MbedTLS as a backend: loading of certificates, implementation of the sign certificate and verify certificates call back. |
@kazuho The tests are failing because this branch somehow picked the wrong version of |
The issue is probably happening when building the docker image in the github actions, but I don't know how to fix that. |
Develop a static function to load file content in memory, as a replacement for the API mbedtls_pk_load_file issue() that is not available in recent versions of MbedTLS.
Also fix missing parentheses in cmake/FindMbedTLS.cmake
Edited on May 16, 2024: the PR now includes the complete code needed for using MbedTLS as a back end.