Enclose field names containing literals in quotes #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When creating the text representation of a path, field names that contain lexer literals (like a period ".') should be enclosed in quotes (or brackets). The proposed fix only adds quotes if needed (as opposed to alway). This avoids changing current paths/behavior drastically since it seems no one has run into this so far. Change-Id: Ia6e01f9b8218182aa61d3c39b16d4bfb57e4f593
Since the pull request for changes has not been merged, enable differentiating which jsonpath-ng is installed. Change-Id: If42cb8aafbb79c8bc7b07a54473eb6ba8da9f50e
Change-Id: Ifb2eab1ebf9151c14b533cf13ef20707bb3ada19
|
@michaelmior Could you please take a look at this pull request? I fixed trivial merge conflicts recently, let me know if you have other suggestions. |
michaelmior
requested changes
Sep 12, 2023
Revert version change, get rid of variable for literals. Change-Id: I381d0a77c6832e96bb0c1f28afc15640c6e953f4
|
Thanks! Merged in 4c1effd |
added 4 commits
September 15, 2023 10:05
Change-Id: Ibdaf122bf2fcd762540dce1437373b166b97c910
Change-Id: Id767180b08a15aa6769f50dac43d09ceedf2875d
Change-Id: Id767180b08a15aa6769f50dac43d09ceedf2875d
|
Looking at this more closely, there are a couple cases that aren't handled here. For example, spaces and double quotes should be enclosed in single quotes also. Single quotes should also be escaped and then quoted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating the text representation of a path, field names that contain lexer literals (like a period ".') should be enclosed in quotes (or brackets).
The proposed fix only adds quotes if needed (as opposed to alway). This avoids changing current paths/behavior drastically since it seems no one has run into this so far.
Change-Id: Ia6e01f9b8218182aa61d3c39b16d4bfb57e4f593