Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Required integration tests and edge-cases list #2

Open
1 of 9 tasks
pospi opened this issue Feb 10, 2019 · 6 comments
Open
1 of 9 tasks

Required integration tests and edge-cases list #2

pospi opened this issue Feb 10, 2019 · 6 comments
Labels
enhancement New feature or request test-writing Issues related to unit or integration tests

Comments

@pospi
Copy link
Member

pospi commented Feb 10, 2019

  • creating, deleting and re-creating a record results in a new record with a different hash (requires implementing creation timestamps)
  • deleting a record of a different type via a deletion method is not possible
  • create event, link fulfillment, modify event, link fulfillment, read fulfillments; validate length = 2
  • can set same link twice without error
  • can re-add the same links again after previously deleted
  • create process, link 2 commitments, ensure process.committedInputs length = 2 and that both commitments are retrievable via QueryParams.input_of search
  • assertions for link index management behaviour when multiple links are present (see test_record_links_cross_*.js)
  • cross-zome linking errors if target is not present (currently soft-erroring in that the value is not persisted)
  • move events where source and destination resource point to the same resource need to be tested to ensure that quantities are correct in both event creation operation output and subsequent resource reads
@pospi
Copy link
Member Author

pospi commented Apr 9, 2019

Working test setup now in https://github.com/pospi/holo-threaded-comments courtesy of @willemolding

@pospi pospi added bug Something isn't working enhancement New feature or request and removed bug Something isn't working labels Apr 9, 2019
@pospi
Copy link
Member Author

pospi commented May 4, 2019

In addition, test/__init.js needs to be updated to generate multiple container configurations for the multiple app DHTs, and multiple agents which will be needed during testing. Ideally, only the resources necessary to test a given scenario are instantiated (i.e. single-agent tests will instantiate only one agent's containers).

@pospi
Copy link
Member Author

pospi commented Jun 3, 2019

Just updating this issue title to refect the current reality.

@pospi pospi changed the title Fix JS tests Add integration tests for multi-DNA functionality Jun 3, 2019
@pospi pospi added this to the Multi-DNA system core milestone Aug 16, 2019
@pospi
Copy link
Member Author

pospi commented Aug 16, 2019

All working, though experiencing some issues with Diorama still.

Newly failing tests since the upgrade to 0.0.27-alpha1 are as follows:

  • updates with fields ommitted leave original value intact
  • links can be written and read between DNAs
  • links can be written and read between zomes

Sorry, something went wrong.

@pospi
Copy link
Member Author

pospi commented Sep 19, 2019

There are now a series of unstarted tests in economic-resource/resource_logic.js that need to be completed once the Specification DNA has been implemented.

@pospi pospi changed the title Add integration tests for multi-DNA functionality Required integration tests and edge-cases list Mar 5, 2020
@pospi
Copy link
Member Author

pospi commented Mar 5, 2020

^resource_logic.js tests are fine now, with the exception of #97.

pospi pushed a commit that referenced this issue Feb 21, 2022
@Connoropolous Connoropolous added this to MMR Mar 5, 2022
@Connoropolous Connoropolous added the test-writing Issues related to unit or integration tests label Mar 11, 2022
@Connoropolous Connoropolous removed this from MMR Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request test-writing Issues related to unit or integration tests
Projects
None yet
Development

No branches or pull requests

2 participants