Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

imp: make system output dynamic #82

Merged
merged 2 commits into from
Jul 14, 2021
Merged

imp: make system output dynamic #82

merged 2 commits into from
Jul 14, 2021

Conversation

blaggacao
Copy link
Collaborator

@blaggacao blaggacao commented Jul 12, 2021 •
edited
Loading

towards #79

@gytis-ivaskevicius
Copy link
Owner

Not suited for HM. Does not exactly solve anything since it lacks arguments that should be used to call builder :/

Maybe we could just code it dynamically so all outputBuilder values would get passed to the main flake? Should not be terribly difficult

@blaggacao
Copy link
Collaborator Author

Maybe we could just code it dynamically so all outputBuilder values would get passed to the main flake? Should not be terribly difficult

Yeah that's a better idea!

@blaggacao blaggacao changed the title imp: add homeConfigurations output imp: make output dynamic Jul 14, 2021
@blaggacao blaggacao changed the title imp: make output dynamic imp: make system output dynamic Jul 14, 2021
gytis-ivaskevicius
gytis-ivaskevicius approved these changes Jul 14, 2021
View reviewed changes
Copy link
Owner

@gytis-ivaskevicius gytis-ivaskevicius left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! But did you execute tests? (Just making sure)

@blaggacao
Copy link
Collaborator Author

Looks great! But did you execute tests? (Just making sure)

I was doing that right now and this seems to trigger an infinite recursion. I'll report back as I learn more.

@blaggacao
imp: allow arguments for devshell checks
5f3e7f9 
This allows to pass --show-trace to the checks
Pacman99
Pacman99 approved these changes Jul 14, 2021
View reviewed changes
Copy link
Collaborator

@Pacman99 Pacman99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! Yeah this works well

@blaggacao
Copy link
Collaborator Author

Both, repo tests as well as downstream tests succeeded with the latest fixup.

@blaggacao blaggacao merged commit 5c6ee69 into staging Jul 14, 2021
@blaggacao blaggacao deleted the hm-ouptut branch July 14, 2021 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gytis-ivaskevicius gytis-ivaskevicius gytis-ivaskevicius approved these changes

@Pacman99 Pacman99 Pacman99 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@blaggacao @gytis-ivaskevicius @Pacman99