Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Django app #4

Open
wants to merge 53 commits into
base: master
Choose a base branch
from
Open

Create Django app #4

wants to merge 53 commits into from

Conversation

SolarLiner
Copy link

... While I'm in it, let's also do a Django app too!

I didn't use the provided project template as it has way too much convenience stuff added, that isn't used here (In fact, Django itself can be considered to be too much for such a simple project, but this is purely educational).

Install Python 3.6, pip and pipenv, and then run pipenv install, and pipenv run start 0.0.0.0:3000 to start the server on port 3000.

$ ./acceptance_test.rb
Run options: --seed 15073

# Running:

...F

Finished in 0.077914s, 51.3390 runs/s, 51.3390 assertions/s.

  1) Failure:
TodoMVPAcceptance#test_the_starting_page_has_the_right_html [./acceptance_test.rb:25]:
--- expected
+++ actual
@@ -17,9 +17,7 @@

     <section class=\"items\">
       <h2>Todo list</h2>
-      <ul>
-
-      </ul>
+      <ul></ul>
     </section>




4 runs, 4 assertions, 1 failures, 0 errors, 0 skips

@ip1981
Copy link

ip1981 commented Dec 7, 2018

No :)

@gypsydave5
Copy link
Owner

Same as for the Flask PR - do you think you could fix the whitespace issue in the template @SolarLiner ?

@SolarLiner
Copy link
Author

Alright here's some more commits - Please do test it because neither the Ruby nor Rust acceptance tests work (Ruby gems don't install properly even though I have all required system libraries), and Rust just seems to complete without doing anything.

Checking manually though, it appears I've solved the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants