fix: remove additional tag on click (Greenstand#710)

Co-authored-by: Nick Charlton <[email protected]>
gwynndp · Jun 28, 2022 · 3bb799b · 3bb799b
1 parent 1f8c84d
commit 3bb799b
Show file tree

Hide file tree

Showing 2 changed files with 1,791 additions and 20 deletions.
diff --git a/src/components/CaptureTags.js b/src/components/CaptureTags.js
@@ -116,10 +116,10 @@ const CaptureTags = (props) => {
     tagsContext.setTagInput(tagsContext.tagInput.concat([chip]));
   };
 
-  const handleDeleteChip = (_chip, index) => {
+  const handleDeleteChip = (_chip) => {
     const temp = tagsContext.tagInput;
-    temp.splice(index, 1);
-    tagsContext.setTagInput(temp);
+    const result = temp.filter((value) => value !== _chip);
+    tagsContext.setTagInput(result);
   };
 
   return (
@@ -157,7 +157,7 @@ const CaptureTags = (props) => {
         value: textFieldInput,
         onBeforeAdd: (chip) => handleBeforeAddChip(chip),
         onAdd: (chip) => handleAddChip(chip),
-        onDelete: (chip, index) => handleDeleteChip(chip, index),
+        onDelete: (chip) => handleDeleteChip(chip),
         pattern: TAG_PATTERN,
         placeholder: props.placeholder,
       }}