Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable -strict for user tests #10038

Open
niloc132 opened this issue Nov 8, 2024 · 0 comments
Open

Enable -strict for user tests #10038

niloc132 opened this issue Nov 8, 2024 · 0 comments
Milestone

Comments

@niloc132
Copy link
Member

niloc132 commented Nov 8, 2024

Follow-up to #10037

With the -strict flag supported for tests, we can use this flag to ensure our source paths are complete and included in module files.

Presently they are not - at least com.google.gwt.testing.TestUtils is referenced by classes that appear in other modules. com.google.gwt.storage.client.MapInterfaceTest for example references TestUtils, but appears in the com.google.gwt.storage.client package, which is part of Storage.gwt.xml.

  • This fails GwtServletBaseTest,
  • which inherits JUnit (note that it shouldn't JUnit is inherited automatically)
  • which inherits User
  • which inherits Storage (not storage test)
  • which includes tests in com.google.gwt.storage.client

Since this fails through the JUnit module, which is automatically inherited by every GWTTestCase module, many tests in gwt-user's own tests would fail in this way. There are likely other issues like this one, but this is the most obvious as it fails most every test.

On the plus side, this validates that -strict works for tests as expected.

niloc132 added a commit to niloc132/gwt that referenced this issue Nov 8, 2024
@niloc132 niloc132 added this to the 2.13 milestone Nov 8, 2024
niloc132 added a commit that referenced this issue Dec 17, 2024
We cannot yet enable this for all of GWT's own tests, see #10038 for
that followup. That said, that failure confirms that this feature is
working as expected.

Fixes #10037
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant