-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve CI and some code cleanup #358
Conversation
add ruff settings to pyproject.toml
- up actions versions - remove flake8 check
Test fail related to HHNK map server... |
I am a bit uncomfortable with skipping the KNMI test, but I am also not fully understanding why it fails. |
The test skip is meant to be temporary. When @martinvonk is back from his holiday, I was planning to let him look into it. Meanwhile we can release the next version of nlmod without being bothered by these failing tests. I thought the KNMI Data Platform functionality wasn't that extensively used, so it would be okay to fix later. |
The test that was skipped is for the KNMI data platform to obtain temporally and spatially distributed meteodata. In the examples we don't use the data from the KNMI data platform. We use the KNMI data obtained via hydropandas. If I remember correctly it is not very useful to use the data from the KNMI data platform yet as there are some weird interpolation results which might mess up the model. Also if you use temporally and spatially distributed meteodata in the model it usually becomes very slow. So we don't have a very good use case for this data yet. |
Ah, I wasn't aware that this was an alternative route for obtaining KNMI data. Thanks both of you for clearing this up. |
Test skips were added in #358 because they failed. Co-Authored-By: Martin Vonk <[email protected]>
Test skips were added in #358 because they failed. Co-Authored-By: Martin Vonk <[email protected]>
Test skips were added in #358 because they failed. Co-Authored-By: Martin Vonk <[email protected]>
Test skips were added in #358 because they failed. Co-Authored-By: Martin Vonk <[email protected]>
See #356.