Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CI and some code cleanup #358

Merged
merged 13 commits into from
Jul 2, 2024
Merged

Improve CI and some code cleanup #358

merged 13 commits into from
Jul 2, 2024

Conversation

dbrakenhoff
Copy link
Collaborator

See #356.

@dbrakenhoff dbrakenhoff linked an issue Jun 27, 2024 that may be closed by this pull request
@dbrakenhoff dbrakenhoff self-assigned this Jun 27, 2024
@dbrakenhoff dbrakenhoff changed the title Improve CI Improve CI and some code cleanup Jun 27, 2024
@dbrakenhoff
Copy link
Collaborator Author

Test fail related to HHNK map server...

@bdestombe
Copy link
Collaborator

I am a bit uncomfortable with skipping the KNMI test, but I am also not fully understanding why it fails.
File not found. Should we introduce logic that solves for the missing data? Or instead of skipping the KNMI test, should we alter the test as the test problem as it is posed now should fail? Or is the user never going to end up in a situation that this error would be relevant?

@dbrakenhoff
Copy link
Collaborator Author

dbrakenhoff commented Jul 2, 2024

The test skip is meant to be temporary. When @martinvonk is back from his holiday, I was planning to let him look into it. Meanwhile we can release the next version of nlmod without being bothered by these failing tests.

I thought the KNMI Data Platform functionality wasn't that extensively used, so it would be okay to fix later.

@OnnoEbbens
Copy link
Collaborator

The test that was skipped is for the KNMI data platform to obtain temporally and spatially distributed meteodata. In the examples we don't use the data from the KNMI data platform. We use the KNMI data obtained via hydropandas. If I remember correctly it is not very useful to use the data from the KNMI data platform yet as there are some weird interpolation results which might mess up the model. Also if you use temporally and spatially distributed meteodata in the model it usually becomes very slow. So we don't have a very good use case for this data yet.

@bdestombe
Copy link
Collaborator

Ah, I wasn't aware that this was an alternative route for obtaining KNMI data. Thanks both of you for clearing this up.

@dbrakenhoff dbrakenhoff merged commit ee6ed3e into dev Jul 2, 2024
4 checks passed
@dbrakenhoff dbrakenhoff deleted the improve_ci branch July 2, 2024 12:04
ArtesiaWater added a commit that referenced this pull request Jul 4, 2024
Test skips were added in #358 because they failed.

Co-Authored-By: Martin Vonk <[email protected]>
ArtesiaWater added a commit that referenced this pull request Jul 4, 2024
Test skips were added in #358 because they failed.

Co-Authored-By: Martin Vonk <[email protected]>
ArtesiaWater added a commit that referenced this pull request Jul 4, 2024
Test skips were added in #358 because they failed.

Co-Authored-By: Martin Vonk <[email protected]>
ArtesiaWater added a commit that referenced this pull request Jul 4, 2024
Test skips were added in #358 because they failed.

Co-Authored-By: Martin Vonk <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve CI
3 participants