Improve output #297
Merged
Improve output #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
dbrakenhoff
reviewed
Nov 29, 2023
| @@ -113,6 +113,28 @@ def xy_to_icell2d(xy, ds): | |||
| return icell2d | |||
|
|
|||
|
|
|||
| def xy_to_row_col(xy, ds): | |||
There was a problem hiding this comment.
This will work on vertex grids as well, do we want to check for that?
There was a problem hiding this comment.
Added check, also in xy_to_icell2d. But I think we should improve these methods, as they will give a wrong result in variable gridsizes, where the closest centre of the cell in not equal to the cell the point is in.
dbrakenhoff
reviewed
Nov 29, 2023
nlmod/mfoutput/mfoutput.py
Outdated
| @@ -88,6 +88,12 @@ def _create_da(arr, modelgrid, times): | |||
| flopy modelgrid object | |||
| times : list or array | |||
| list or array containing times as floats (usually in days) | |||
| add_nans : bool, optional | |||
There was a problem hiding this comment.
Nothing major, but maybe dry_nans = True is a bit clearer, instead of add_nans.
dbrakenhoff
reviewed
Nov 29, 2023
|
|
||
| df = nlmod.read.geotop.get_kh_kv_table() | ||
| gt = nlmod.read.geotop.add_kh_and_kv(gt, df) | ||
| # again, but using the stochastic method |
There was a problem hiding this comment.
seems like stochastic is already tested in line before? Maybe modify comment to indicate why second test is different from first?
There was a problem hiding this comment.
Added more comments
dbrakenhoff
approved these changes
Nov 29, 2023
Remove add_nans again, and just use the value for hdry or hnoflo to not add NaNs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request does the following: