Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NaN in drain package #213

Closed
tomvansteijn opened this issue Jul 31, 2023 · 2 comments · Fixed by #249
Closed

NaN in drain package #213

tomvansteijn opened this issue Jul 31, 2023 · 2 comments · Fixed by #249
Assignees

Comments

@tomvansteijn
Copy link

When calling the function nlmod.gwf.drn NaN's are printed in the drain package file. This results in a Fortran error when trying to run the model. Within the function, a mask is created based on the conductance being not equal to zero:

mask = mask_arr != 0

However this is also true for NaN. Perhaps the expression should be adjusted?

To be pedantic, the term 'mask' is used in the opposite sense (all other values are masked).

@tomvansteijn
Copy link
Author

Perhaps the expression should be changed to:

mask = mask_arr > 0

This excludes NaN and ofcourse conductance is always positive.

@OnnoEbbens
Copy link
Collaborator

Hi Tom, thanks for pointing this out. I agree with your solution. Would you like to make a Pull Request for this? If not I am happy to make one as well.

@dbrakenhoff dbrakenhoff self-assigned this Aug 24, 2023
dbrakenhoff added a commit that referenced this issue Aug 25, 2023
- add RIV pkg #97
- fix mask checks in bc pkgs #213
- add check on dataarray coords #214
@dbrakenhoff dbrakenhoff linked a pull request Aug 25, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants