test: ensure eigenvectors property not present with eigenvectors: fal…

…se option
gwhitney · Oct 18, 2023 · a5ebd0c · a5ebd0c
1 parent cf60b8c
commit a5ebd0c
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 8 deletions.
diff --git a/src/function/matrix/eigs/complexEigs.js b/src/function/matrix/eigs/complexEigs.js
@@ -42,13 +42,12 @@ export function createComplexEigs ({ addScalar, subtract, flatten, multiply, mul
     // (So U = C^-1 arr C and the relationship between current arr
     // and original A is unchanged.)
 
-    let eigenvectors
-
     if (findVectors) {
-      eigenvectors = findEigenvectors(arr, N, C, R, values, prec, type)
+      const eigenvectors = findEigenvectors(arr, N, C, R, values, prec, type)
+      return { values, eigenvectors }
     }
 
-    return { values, eigenvectors }
+    return { values }
   }
 
   /**

diff --git a/test/unit-tests/function/matrix/eigs.test.js b/test/unit-tests/function/matrix/eigs.test.js
@@ -107,10 +107,9 @@ describe('eigs', function () {
     approx.deepEqual(fullValues,
       [-0.9135495807127523, 2.26552473288741, 5.6502090685149735, -8.687249803623432]
     )
-    assert.deepStrictEqual(
-      fullValues,
-      eigs(sym4, { eigenvectors: false }).values
-    )
+    const justEigs = eigs(sym4, { eigenvectors: false })
+    assert.deepStrictEqual(fullValues, justEigs.values)
+    assert.ok(!('eigenvectors' in justEigs))
   })
 
   it('calculates eigenvalues and eigenvectors for 5x5 matrix', function () {
@@ -162,6 +161,7 @@ describe('eigs', function () {
     testEigenvectors(ans,
       (v, j) => approx.deepEqual(multiply(E[j], v), multiply(H, v))
     )
+    assert.ok(!('eigenvectors' in justvalues))
     const Vcols = ans.eigenvectors.map(obj => obj.vector)
     const V = matrixFromColumns(...Vcols)
     const VtHV = multiply(transpose(V), H, V)
@@ -250,6 +250,7 @@ describe('eigs', function () {
     // Make sure the precision argument can go in the options object
     const stillbad = eigs(difficult, { precision: 1e-14, eigenvectors: false })
     assert.deepStrictEqual(stillbad.values, poor.values)
+    assert.ok(!('eigenvectors' in stillbad))
   })
 
   it('diagonalizes matrix with bigNumber', function () {
@@ -268,6 +269,7 @@ describe('eigs', function () {
     const ans = eigs(H)
     const justvalues = eigs(H, { eigenvectors: false })
     assert.deepStrictEqual(ans.values, justvalues.values)
+    assert.ok(!('eigenvectors' in justvalues))
     const E = ans.values
     const Vcols = ans.eigenvectors.map(obj => obj.vector)
     const V = matrixFromColumns(...Vcols)