Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

significance bug for trigger_fit #4407

Merged
merged 2 commits into from
Jun 23, 2023
Merged

significance bug for trigger_fit #4407

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
181cc13
significance bug for trigger_fit. A couple of minor fixes
GarethCabournDavies Jun 16, 2023
45ace79
Merge branch 'gwastro:master' into significance_trigger_fit_bugfix
GarethCabournDavies Jun 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions pycbc/events/significance.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,10 +159,10 @@ def n_louder_from_fit(back_stat, fore_stat, dec_facs,
count_n_louder(back_stat[bg_below], fore_stat[fg_below], dec_facs)

# As we have only counted the louder below-threshold events, need to
# add the above threshold events, whcih by definition are louder than
# add the above threshold events, which by definition are louder than
# all the below-threshold events
back_cnum += n_above
fnlouder += n_above
back_cnum[bg_below] += n_above
fnlouder[fg_below] += n_above

return back_cnum, fnlouder

Expand Down