Introduced a new arguement --skymap-only-ifos in pycbc_live #4346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @SouradeepPal. It looks like this is making the PyCBC Live test fail. Could you have a look? |
bin/pycbc_live
Outdated
| """Figure out which of the followup detectors are usable, and compute | ||
| SNR time series for all the available detectors. | ||
| """ | ||
| out = {} | ||
| followup_ifos = [] if followup_ifos is None else followup_ifos | ||
| skymap_only_ifos = [] if skymap_only_ifos is None else skymap_only_ifos |
There was a problem hiding this comment.
Can you set the default value in kwargs to be [], and then you don't have this bit?
There was a problem hiding this comment.
No, that is not a good idea. What @SouradeepPal did initially is the recommended approach.
There was a problem hiding this comment.
bin/pycbc_live
Outdated
| @@ -910,6 +925,8 @@ parser.add_argument('--enable-embright-has-massgap', action='store_true', defaul | |||
| parser.add_argument('--embright-massgap-max', type=float, default=5.0, metavar='SOLAR MASSES', | |||
| help='Upper limit of the mass gap, used for estimating ' | |||
| 'HasMassGap probability.') | |||
| parser.add_argument('--skymap-only-ifos', nargs='+', default=['V1', 'K1'], | |||
There was a problem hiding this comment.
Small problem here that there is no way that I can see to set none of the ifos to be skymap-only. I would set the default to be [].
There was a problem hiding this comment.
Hi Gareth, all the changes you suggested have been made.
There was a problem hiding this comment.
Thanks! I'll let @titodalcanton hit the approve button, in case there was anything else I missed
bin/pycbc_live
Outdated
Comment on lines
916
to
917
| parser.add_argument('--skymap-only-ifos', nargs='+', default=[], | ||
| help="IFOs that only contribute in sky localization") |
There was a problem hiding this comment.
Do not set defaults here. Also, replace "IFOs" with "detectors" in the help string.
bin/pycbc_live
Outdated
| @@ -1100,7 +1108,7 @@ with ctx: | |||
| args.max_psd_abort_distance) | |||
| status = False | |||
|
|
|||
| if status is True: | |||
| if ifo not in skymap_only_ifos and status is True: | |||
There was a problem hiding this comment.
This logic is not really what we want, because it will print "Insufficient data for %s analysis" even if a detector is a skymap-only detector.
bin/pycbc_live
Outdated
|
|
||
| # Check for singles | ||
| if args.enable_single_detector_background: | ||
| evnt.check_singles(results, psds) | ||
| evnt.check_singles(results, psds, skymap_only_ifos=skymap_only_ifos) |
There was a problem hiding this comment.
I think you can simplify the code if you set skymap_only_ifos to be an attribute of the LiveEventManager class. Then you do not need to carry around all these arguments.
There was a problem hiding this comment.
This is what I had initially thought, but dropped the idea seeeing that ifos is not an attribute of the LiveEventManager. Is there a reason. Now I have added skymap_only_ifos as an attribute which seems to have simplified things. But the test failed which I cannot understand atm. Where should I look at to debug.
There was a problem hiding this comment.
The test failure seems to be a condor installation issue - I will click to restart failed tests in case this was a transient thing, but we may need a fix elsewhere if it isnt
|
I think this is okay to merge now - @titodalcanton do you agree? |
|
No, I would like to see at least a minimal proof that this works correctly before merging. |
|
Okay - @SouradeepPal can you provide an example of this running? You should be able to modify the example in |
|
I am retrying but last time I had to stop here: https://git.ligo.org/pycbc/action-items/-/issues/23#note_712046 |
|
Hi, some changes have been made in But there are two of them each with same Other skymaps with singles look okay from both HLV and HLv or where there is a LV coinc in HLV .. |
|
@SouradeepPal Checking I've understood: The second row of plots are both from the standard HLV analyses, and we think that one of these is the SNR optimized event? The third row is from the new HLv analyses, again we think that one of these is SNR optimized, but worry it may not have used V? Can you point me to the trigger directory for both triggers in the bottom row? |
|
Yes, that is what I am guessing. Triggers for HLv are in Caltech, here : |
|
Okay, it seems that one of these triggers is a H1 single, which included L1 as a "followup detector" and a H1L1 double, which included V1 as a followup detector. So question is, why did the singles analysis not include V1. The optimize_snr is done in a subdirectory (of the H1L1 double trigger) called |
|
Thanks, HLv skymaps now: which is now identical to the HLV case. The Interestingly, the same error log is also present in one of the HLV triggers.. while another HLV trigger seems to have successfully run the optimized thing.. |
|
I would like to be sure the the optimize_snr failure is not caused by this patch. Is it possible to try running the example (HLV) with this patch not applied, and see if we can get the same failure? |
|
A fresh install of the main branch already has the following: |
|
The XLAL Errors are just warnings in this case, you should be able to see some form of output from the code in this case?? |
|
No, all these got dumped in the log file, no other files were generated |
|
Where is this new directory, so I can check the log? |
|
Here: |
|
Okay, that directory looks like optimize_snr was working, but I think it was terminated because it just took too much time. |
|
Ok , timeout also happened: But for that the log file looks different: |
|
Well
However, the times are different, so it feels like I'm not comparing like-for-like here(??) |
|
A few more tries without this patch applied (or on the commit above) seem to not fail like that with the patch applied (but have other XLAL Error and timeouts).. So I wanted to understand what might be causing it, here it seems that the process starts, continues for ~ 2min and then fails due to something- so likely not that any missing/misbehaving input file? (I am again pasting the complete log for 1272790260 here at Also wanted to flag slightly different error also occured in one of the tests, at |
|
Could you rebase to master? I think this could be solved by #4338, but I'm not 100% |
|
|
I had synced fork, now I accidentally closed the pr! |
|
I guess my only concern with this is ensuring that the optimizer gets the right data for V1 in the case of V1 being used as a skymap-only ifo. Maybe this could be checked in different ways (e.g. comparing data with/without the skymap-only-ifo flag that the optimizer gets sent).I do agree that the optimizer before the patch Gareth mentions may never have worked well in the cases here. |
|
With the patch that Gareth mentioned, till now I could not find any error, but yes the files |
spxiwh
approved these changes
Jul 3, 2023
There was a problem hiding this comment.
@SouradeepPal Okay thanks. I think this is now ready to move over to testing in the MDC (@titodalcanton). I'm giving approval to merge, but please remove the commented lines first as requested (this should also restart the CI tests), then we can merge.
spxiwh
reviewed
Jul 3, 2023
pycbc/io/live.py
Outdated
| @@ -195,11 +195,11 @@ def __init__(self, coinc_ifos, ifos, coinc_results, **kwargs): | |||
| # assumptions and checks | |||
| bayestar_check_fields = ('mass1 mass2 mtotal mchirp eta spin1x ' | |||
There was a problem hiding this comment.
bayestar_check_fields and the comment above should also now be removed, as it is now unused.
|
@SouradeepPal to deal with the question of why things are reproducible or identical, we suggested on the call to give the random seed option in optimize_snr a default value (eg 42 ..) so that it's always used unless someone overrides it. |
|
@tdent I was basically ready to press the merge button on this. Do you want to hold up to make that change ... or not? |
|
We had discussion on the pycbc call and from what I remember I don't know if Tito was convinced by the testing and it didn't seem like there was a consensus that this should be merged immediately. |
|
FWIW, as far as I can see the previous optimizer errors should be addressed by the recent commits that fix the mass ranges to be 'saner'. So we don't expect any such errors to persist with the current state of the code |
|
It seems fixing the The contents of the So I have pushed a default of 42 for the seed arg in the optimize_snr code. Is that okay. |
I remove an unnecessary FIXME in the comments, but mostly doing this to restart the CI tests, which seem to have not linked up right.
|
Okay, I'll merge this now as soon as I can persuade the CI tests to pass. |
|
@SouradeepPal Unfortunately this needs to be rebased again. :-( |
bhooshan-gadre
pushed a commit
to bhooshan-gadre/pycbc
that referenced
this pull request
Jul 11, 2023
…4346) * Introduced a new arguement --skymap-only-ifos in pycbc_live * Default skymap_only_ifos changed * skymap_only_ifos as an attribute of LiveEventManager * Test skymaps with V1 as skymap_only_ifos * singles with skymap_only_ifos * Removing commented lines etc * A default seed for SNR opt * Poking CI tests I remove an unnecessary FIXME in the comments, but mostly doing this to restart the CI tests, which seem to have not linked up right. --------- Co-authored-by: Souradeep Pal <[email protected]> Co-authored-by: Ian Harry <[email protected]>
tdent
added a commit
that referenced
this pull request
Jul 26, 2023
* Try to fix CI tests (#4394) * Switch FFTW/MKL order of preference * Swap backend order and force gomp import * FIx typo * Do need openmpi in tox.ini * Fix bug in MKL error function * Force FFTW on this one. * CC * Requested Josh changes * Add bank corner plot (#4339) * Add corner plotting script for template banks * Comment where premerger duration has been subtracted from template duration in bank_conversions * add premerger_duration to bank_conversions.py * Move premerger duration into bank_conversions * Use bank's approximant * Dont plot signular values as default * CC complaints * docstring * TDC comments * Keep approximant kwarg as default, TDC comments 2 * Added an OSError exception to MKL check (#4390) * Add a possibility for defaultvalues sections in config files (#4385) * Add a possibility for defaultvalues sections in config files * do not allow [section] and [section-defaultvalues] options * defaultvalues for top-level sections only * underscore on add_ini_opts * Remove default sections from get_subsections (#4399) * Update setup-python action to v4 (#4400) * Replace LOSC with GWOSC (#4401) * Replace LOSC with GWOSC * Fix leftover Python 2-ism * Try to improve codeclimate * Try to fix codeclimate * Try to fix codeclimate * Try to fix codeclimate * Exclude IFO sections when looping through the get_subsections (#4402) * Exclude IFO sections when looping through the get_subsections for plots * Add an example whihc would have previously failed into the search config * Offline singles in workflow (#4386) * Add single-detector options into workflow * Fix a couple of isses which make results pages weird * fix * fix gen.sh to use correct workflow generator * revert change made in error * A couple of points which state coincident when it may not be * Rejection samp (#4379) * unexpected events * added temp-volume in cl * added rejection sampling * added indexing of mchirp in fit_param * added compensation factor * added corrections * added more corrections * added random number generator seed * added mchirp instead of log(mchirp) in rejection samp * Use probabilities to compensate downsampled kde * Try to deal with flaky failures when apt-getting (#4384) * Implement pre-cuts in fit_over_multiparam for efficiency (#4374) * Make some efficiency savings in pycbc_fit_sngls_over_multiparam * Missing logging line in once case * Add in progress reporting, in case of silent failure * I thought we needed some leeway, but we don't * TD comments * Simplify comment * Migrate to new gwdatafind API (#4383) * Migrate to new gwdatafind API * CC and one regression fix * One more style change * Don't need these options now * Revert "Don't need these options now" This reverts commit 6f2ed1b. * Add a Fisher distribution for sky locations (#4209) * Update transforms.py Adding new_z_to_euler and rotate_euler from pylal.sphericalutils * Update sky_location.py Added new class FisherDist for drawing from sky locations (in ra, dec) * Update sky_location.py Included help message for fisherDist * Update sky_location.py * Code climate issues * Code climate issues * Code-climate changes * Code climate issues * Code climate issues * Update transforms.py changed lal.PI to numpy.pi in new_z_to_euler * Update transforms.py minor changes * Update sky_location.py updated docstring, did changes to make the code look more simple * Update sky_location.py typos corrected * Update sky_location.py code climate changes * Update sky_location.py * Update sky_location.py Included the definitions rvs_polaz and rvs_radec * Update transforms.py Included the definitions decra2polaz and polaz2decra * Update sky_location.py * Update transforms.py code climate issues fixed * Update sky_location.py code climate issues fixed * Update sky_location.py code climate issues * Update sky_location.py fixed code climate issues * Update sky_location.py fixed code climate issues * Update sky_location.py * Update pycbc/distributions/sky_location.py Co-authored-by: Tito Dal Canton <[email protected]> * Update sky_location.py * Update sky_location.py * Update transforms.py modified polaz2decra to polaz2radec * Update sky_location.py * Update sky_location.py Forgotten polaz2decra --> polaz2radec * Update sky_location.py Code climate fixes * Update sky_location.py Updated the code for checking the effectiveness of running from config file * Create sky_location_old.py * modified to include from config * Modified to run from config file * Added Fisher distribution to the lista of available distributions * Delete sky_location_old.py * Update sky_location.py * Renamed Fisher to FisherSky * Updated the name to FisherSky * changed Fisher to FisherSky in __all__ * removed decra2polaz and polaz2radec to conversions * Included def decra2polaz, polaz2radec in line 859 * Added angle_unit option * removed decra2polaz and polaz2decra * made carresction * made corrections * Corrected the typing error while removing recra2polaz * Modified angle_unit and updated init file * Empty line on 852 retrieved * corrected * Empty line on852 retrieved * Fixed code climate issues * Sigma conversion taken care of * Fixed code climate issues * Update sky_location.py Codeclimate * Update test_distributions.py Adding fisher_sky to the list of distributions that do not undergo the distribution unittests. * Update sky_location.py Syntax fixed. * Update sky_location.py complying to codeclimate * Refactor using scipy's Rotation * Improve docstring and make warning stricter * Update pycbc/distributions/sky_location.py Co-authored-by: Francesco Pannarale <[email protected]> * Update pycbc/distributions/sky_location.py right angle to correct angle Co-authored-by: Francesco Pannarale <[email protected]> * Update sky_location.py logging issue solved --------- Co-authored-by: Francesco Pannarale <[email protected]> Co-authored-by: Tito Dal Canton <[email protected]> Co-authored-by: P Prasia <[email protected]> Co-authored-by: Tito Dal Canton <[email protected]> * add in several missing marginalization combinations (#4376) * allow polarization marginalization with earth rotation * add in missing marg combos * fixes * fixes * fixes * cleanup * cc * cc * Try to fix CI tests (#4394) * Switch FFTW/MKL order of preference * Swap backend order and force gomp import * FIx typo * Do need openmpi in tox.ini * Fix bug in MKL error function * Force FFTW on this one. * CC * Requested Josh changes * Add bank corner plot (#4339) * Add corner plotting script for template banks * Comment where premerger duration has been subtracted from template duration in bank_conversions * add premerger_duration to bank_conversions.py * Move premerger duration into bank_conversions * Use bank's approximant * Dont plot signular values as default * CC complaints * docstring * TDC comments * Keep approximant kwarg as default, TDC comments 2 * Added an OSError exception to MKL check (#4390) * Add a possibility for defaultvalues sections in config files (#4385) * Add a possibility for defaultvalues sections in config files * do not allow [section] and [section-defaultvalues] options * defaultvalues for top-level sections only * underscore on add_ini_opts * Remove default sections from get_subsections (#4399) * Update setup-python action to v4 (#4400) * Replace LOSC with GWOSC (#4401) * Replace LOSC with GWOSC * Fix leftover Python 2-ism * Try to improve codeclimate * Try to fix codeclimate * Try to fix codeclimate * Try to fix codeclimate * Exclude IFO sections when looping through the get_subsections (#4402) * Exclude IFO sections when looping through the get_subsections for plots * Add an example whihc would have previously failed into the search config * Offline singles in workflow (#4386) * Add single-detector options into workflow * Fix a couple of isses which make results pages weird * fix * fix gen.sh to use correct workflow generator * revert change made in error * A couple of points which state coincident when it may not be --------- Co-authored-by: Thomas Dent <[email protected]> Co-authored-by: Ian Harry <[email protected]> Co-authored-by: Gareth S Cabourn Davies <[email protected]> Co-authored-by: Prasia-Pankunni <[email protected]> Co-authored-by: Francesco Pannarale <[email protected]> Co-authored-by: Tito Dal Canton <[email protected]> Co-authored-by: P Prasia <[email protected]> Co-authored-by: Tito Dal Canton <[email protected]> Co-authored-by: Alex Nitz <[email protected]> Co-authored-by: Arthur Tolley <[email protected]> Co-authored-by: Tito Dal Canton <[email protected]> * Adding SEOBNRv5Peak key and function in the final frequency cutoff dictionary (#4408) Co-authored-by: KHUN PHUKON <[email protected]> * Injection kde (#4409) * unexpected events * added temp-volume in cl * added injection kde * significance bug for trigger_fit. A couple of minor fixes (#4407) * Upgrades to pycbc_grb_inj_finder (#4364) * retaining single ifo injection information * Update pycbc_grb_inj_finder Update according to requested changes from pull request review. * Adding more specific comments Co-authored-by: Francesco Pannarale <[email protected]> * Adding more specific comments out_dict changed to "output dictionary" in comment Co-authored-by: Francesco Pannarale <[email protected]> * Remove xlen Removed xlen from cp_dataset_cont and instead calculated the length of xidentifier within the function. * Reverting comment changes * Remove extra comment * Francesco's bug fix Modified to simplify and correct where ifo information was jumbled together * remove trig_dict and comment * Removed extra lines Removed line and datasets = {} * Update to copyright comment and imports Added our names and accounted for older python version. --------- Co-authored-by: Francesco Pannarale <[email protected]> * Simple bugfix (#4413) Co-authored-by: Bhooshan Gadre <[email protected]> * Move PyCBC venvs to new IGWN CVMFS server (#4412) * First part of moving venv build to igwn * TESTING HACK. REVERT ME BEFORE MERGING!!! * Try this * Testing * Revert "Testing" This reverts commit c0b9ea0. * Add new CVMFS commands * Remove rsync filter which isn't working * Add error wrap abort handler * Update tools/venv_transfer_commands.sh Co-authored-by: Duncan Macleod <[email protected]> * Fix Ian's idiocy (attempt to) and HostChecking * Set to abort for one last test * One final publish test * Add a chmod on the root CVMFS directory * Prepare for merging * Fix mistake --------- Co-authored-by: Duncan Macleod <[email protected]> * Get FFT options in pycbc_condition_strain (#4404) * pycbc_optimize_snr: Implement mass dependent bounds on spin parameters (#4176) * Applying spin bounds based upon object mass~ * Updated reference to correct paper * Adding spin bounds based on upper bounds of masses * removing unnecessary additions * Changing max mass2 to the right quantities * Creating maxeta + reusing maxm1 * minor cleanup * fixed min / max eta values * fixed min / max eta * Correcting maxm2 equation * more readable/less redundant comment --------- Co-authored-by: Thomas Dent <[email protected]> * Allow SNR optimizer to use candidate point in initial array (#4393) * allow SNR optimizer to use the candidate point in the initial array of test points * update two LISA docs (#4417) * Update injection_smbhb.ini * Update lisa_smbhb_relbin.ini * Update lisa_smbhb_relbin.ini * Update lisa_smbhb_relbin.ini * Update lisa_smbhb_ldc_pe.rst * Allow pycbc_multi_inspiral to search over a sky grid (#4380) * Allow pycbc_multi_inspiral to search over a sky grid * Adding the possibility to give either a sky grid or a sky position * Change the names of the command lines --ra and --dec to --latitude and --longitude to match the changes made in pycbc_multi_inspiral and remove --processing-scheme because it makes the example crash * Compute the antenna pattern only once for each sky position by keeping fp and fc together * Replace the number of detectors from a hardcoded value to a variable * add TDI AE PSD with confusion noise for LISA (#4389) * add TDI AE PSD with confusion noise * Update analytical_space.py * fix cc issue * Update analytical.py * EM brute (#4299) * Space before colons in eos_utils.py help messages * Enable extrapolation in eos_utils.py when NS is out of bounds * Same check on shape in primary_mass and secondary mass * Function to swap masses and spins of object 1 and object2 * Allow user to request for remnant_mass calculations: 1) extrapolation, 2) swapping object 1 and object 2 if mass2 > mass1, 3) treat as a (dark) BBH and NSBH with NS mass greater than a value probided by the user * Renamned swap_companions to ensure_obj1_is_primary and generalized it * codeclimate * codeclimate * Fixed line that was too long * Fixed docstring and using keywords explicitly in all remnant_mass_* calls * Renamed max_ns_mass as ns_bh_mass_boundary and improved help messages of functions * Improved docstings * Comprehensions in pycbc_brute_bank * Complying to naming convention for spin components in spherical coordinates * Update conversions.py Fixing single code climate complaint. * Prevent duplicates of the HLV page_ifar plot on the summary page (#4421) * Prevent duplicates of the HLV page_ifar plot on the summary page * Rename 'coincidences' as appropriate * add high frequency sky location dependent response for long detectors (#4377) * reset commit, add in high freqeuncy response to detector * update * fixes * Make pegasus 5.0.5 work (#4276) * Revert "try pinning pegasus version (#4265)" This reverts commit 398e135. * Set for_planning flag for subworkflow output map * Add version check so we don't break 5.0.3 * Also include 5.0.4 * make ci faster (#4414) * update * move long log into debug level, allow to set debug level * fix workflow * more explicit control of running external scripts for docs setup at same time * fixes * update * try this * try this ... * update * fixes * update * updates * mistake in example search config file (#4425) * mistake in example search config file * add failure if search runs too long * Range_temp kde (#4424) * unexpected events * added temp-volume in cl * setting the range for temp_kde * setting min based on max kde * logging for min template kde ratio --------- Co-authored-by: Thomas Dent <[email protected]> * Pygrb offline workflow (#4288) * Fixed indexing and autochisq argument in pycbc_multi_inspiral * Only Hanford is labelled with a 1: avoiding pycbc_pygrb_plot_snr_timeseries failure. trigs rather than trigs_or_injs as variable name in pycbc_pygrb_plot_coh_ifosnr * Simplified and update pycbc_pygrb_plot_injs_results; adapted pycbc_pygrb_pp_workflow * Forgotten comma * Massive commit that stitches together pycbc_make_offline_grb_workflow and pycbc_pygrb_pp_workflow, by picking up the latter as a SubWorkflow. * Massive commit that stitches together pycbc_make_offline_grb_workflow and pycbc_pygrb_pp_workflow, by picking up the latter as a SubWorkflow. * Code-climate fixes * More code-climate * Import error flagged by code-climate * Forgotten import fixes * Minor cleanup of comments or commented out code lines * Syntax fix * Defining 2 empty file lists * First part of PR 4288 review comments * One more TODO * opt_to_file is now configparser_value_to_file in pycbc/workflow/core.py * Upgraded configparser_value_to_file with attrs keyword argument * Using configparser_value_to_file throughout the PyGRB workflow generator * Removing 2 unused PyGRB functions * Removed LigolwCBCAlignTotalSpinExecutable, LigolwCBCJitterSkylocExecutable, and PycbcDarkVsBrightInjectionsExecutable support in general and removed LalappsInspinjExecutable support from PyGRB * Codeclimate * bank_veto_file variable needs to be a FileList, not a File * Bug with tags for single IFO SNR plots workflow generator * Fixing pycbc_pygrb_plot_coh_ifosnr * Fixing layout of chi-square plots and section label for individual detector SNRs * Codeclimate * Codeclimate * Codeclimate * Removed FIXME for testing purposes * First changes following up on PR review * Second round of changes following up on PR review * Flagging with an underscore grb utility functions not used outside the files they are defined in * Flagging with an underscore grb utility functions not used outside the files they are defined in * Removed _get_antenna_factors from PyGRB utily file * Removed commented out function from pycbc_pygrb_plot_injs_results * Substituted old unused code with a TODO * Adding injection set name as an option in pycbc_pygrb_efficiency * extend --> append for single files * Documenting setup_pygrb_pp_workflow more appropriately * Reverted name of _get_antenna_responses to get_antenna_responses; cleaner handling of bank-veto-bank-file for pycbc_multi_inspiral job setup. * Line shortened * Avoid skymap v1.1.0 (#4429) * only download LISA response file once (#4423) * Update analytical_space.py * Update analytical_space.py * Introduced a new arguement --skymap-only-ifos in pycbc_live (#4346) * Introduced a new arguement --skymap-only-ifos in pycbc_live * Default skymap_only_ifos changed * skymap_only_ifos as an attribute of LiveEventManager * Test skymaps with V1 as skymap_only_ifos * singles with skymap_only_ifos * Removing commented lines etc * A default seed for SNR opt * Poking CI tests I remove an unnecessary FIXME in the comments, but mostly doing this to restart the CI tests, which seem to have not linked up right. --------- Co-authored-by: Souradeep Pal <[email protected]> Co-authored-by: Ian Harry <[email protected]> * Fix stageout (#4428) * Fix the help message for stageout script * Fix the help message for stageout and copy map scripts --------- Co-authored-by: connor-mcisaac <[email protected]> * more physical rwrap for LISA SMBHB/SOBHB injection (follow-up fix 2) (#4350) * more physical rwrap * fix cc issues * Update waveform.py * Update companion.txt * Update requirements.txt * Update requirements.txt * Update companion.txt * 10 times tau * Update companion.txt * Update requirements.txt * Update setup.py * add check * Update waveform.py * allow user to choose rwarp * fix cc issue * set 0.2 as minimum rwrap * Update waveform.py * Remove most X509/globus links and hooks from PyCBC (#4375) * Remove most X509/globus links and hooks from PyCBC * Need to update this one as well * Don't need these options now * Update docs/workflow/pycbc_make_coinc_search_workflow.rst Co-authored-by: Gareth S Cabourn Davies <[email protected]> --------- Co-authored-by: Gareth S Cabourn Davies <[email protected]> * fftw_fix (#4418) * Allow pycbc inspiral to run with only numpy fft * Remove Unneeded function from npfft.py --------- Co-authored-by: Neeresh Kumar Perla <[email protected]> * Add argument verification for singles (#4365) * Add argument verification for singles * Apply suggestions from code review * remove --enable-single-detector-background * Some more option-checking, and making fixed ifar option actually possible! * fix options in example * CC, typo * CC * Move versioning page generation into its own executable (#4431) * Move versioning page generation into its own executable * Allow duplicated executables * 🤦 * CC changes * CC * save_fig_with_metadata cannot be imported from versioning * Don't like spaces in arguments * Ian's comments * Dont pass executables as files * Same type output from get_code_version_numbers * Rename --longitude and --latitude back to --ra and --dec (#4433) * bugfix - allow non-running of singles (#4439) * bugfix - allow non-running of singles * CC * Revrt wrongly-added test chnages * Add IMRPhenomXAS template duration (#4410) * Add IMRPhenomXAS template duration * removing assertion * fixed fomatting for codeclimate * Adding PhenomXAS duration and removing space fixes * removing extra new line --------- Co-authored-by: Bhooshan Gadre <[email protected]> * Treat CVMFS better (#4440) * dqsegdb2 update (#4442) * dqsegdb2 update * Update requirements-igwn.txt Co-authored-by: Duncan Macleod <[email protected]> --------- Co-authored-by: Ian Harry <[email protected]> Co-authored-by: Duncan Macleod <[email protected]> --------- Co-authored-by: Ian Harry <[email protected]> Co-authored-by: Gareth S Cabourn Davies <[email protected]> Co-authored-by: Arthur Tolley <[email protected]> Co-authored-by: Tito Dal Canton <[email protected]> Co-authored-by: Praveen Kumar <[email protected]> Co-authored-by: Prasia-Pankunni <[email protected]> Co-authored-by: Francesco Pannarale <[email protected]> Co-authored-by: Tito Dal Canton <[email protected]> Co-authored-by: P Prasia <[email protected]> Co-authored-by: Tito Dal Canton <[email protected]> Co-authored-by: Alex Nitz <[email protected]> Co-authored-by: Khun Sang Phukon <[email protected]> Co-authored-by: KHUN PHUKON <[email protected]> Co-authored-by: ETVincent <[email protected]> Co-authored-by: Bhooshan Uday Varsha Gadre <[email protected]> Co-authored-by: Bhooshan Gadre <[email protected]> Co-authored-by: Duncan Macleod <[email protected]> Co-authored-by: Shichao Wu <[email protected]> Co-authored-by: hoangstephanie <[email protected]> Co-authored-by: SouradeepPal <[email protected]> Co-authored-by: Souradeep Pal <[email protected]> Co-authored-by: Ian Harry <[email protected]> Co-authored-by: connor-mcisaac <[email protected]> Co-authored-by: Neeresh Kumar <[email protected]> Co-authored-by: Neeresh Kumar Perla <[email protected]>
PRAVEEN-mnl
pushed a commit
to PRAVEEN-mnl/pycbc
that referenced
this pull request
Nov 3, 2023
…4346) * Introduced a new arguement --skymap-only-ifos in pycbc_live * Default skymap_only_ifos changed * skymap_only_ifos as an attribute of LiveEventManager * Test skymaps with V1 as skymap_only_ifos * singles with skymap_only_ifos * Removing commented lines etc * A default seed for SNR opt * Poking CI tests I remove an unnecessary FIXME in the comments, but mostly doing this to restart the CI tests, which seem to have not linked up right. --------- Co-authored-by: Souradeep Pal <[email protected]> Co-authored-by: Ian Harry <[email protected]>
titodalcanton
pushed a commit
to titodalcanton/pycbc
that referenced
this pull request
Jan 16, 2024
…4346) * Introduced a new arguement --skymap-only-ifos in pycbc_live * Default skymap_only_ifos changed * skymap_only_ifos as an attribute of LiveEventManager * Test skymaps with V1 as skymap_only_ifos * singles with skymap_only_ifos * Removing commented lines etc * A default seed for SNR opt * Poking CI tests I remove an unnecessary FIXME in the comments, but mostly doing this to restart the CI tests, which seem to have not linked up right. --------- Co-authored-by: Souradeep Pal <[email protected]> Co-authored-by: Ian Harry <[email protected]>
acorreia61201
pushed a commit
to acorreia61201/pycbc
that referenced
this pull request
Apr 4, 2024
…4346) * Introduced a new arguement --skymap-only-ifos in pycbc_live * Default skymap_only_ifos changed * skymap_only_ifos as an attribute of LiveEventManager * Test skymaps with V1 as skymap_only_ifos * singles with skymap_only_ifos * Removing commented lines etc * A default seed for SNR opt * Poking CI tests I remove an unnecessary FIXME in the comments, but mostly doing this to restart the CI tests, which seem to have not linked up right. --------- Co-authored-by: Souradeep Pal <[email protected]> Co-authored-by: Ian Harry <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new argument
--skymap-only-ifosforpycbc_livethat accepts a list of IFOs to be used in skymap-only followup. These ifos should now be skipped during the regular matched-filtering, coincidence making, background estimation..