ues sky_simple crash

[luohuiiqng]

Hello, I have tried to use osgEarth: : SimpleSky: : SimpleSkyOptions to replace osgEarth: : SkyOptions to obtain better effect of the sky. But the effect after the replacement is not better, what can I improve?
Thank you!

#include <Windows.h>
#include <osgViewer/viewer>
#include <osgEarth/Notify>
#include <osgEarth/EarthManipulator>
#include <osgEarth/MapNode>
#include <osgEarth/Threading>
#include <osgEarth/ShaderGenerator>
#include <osgDB/ReadFile>
#include <osgGA/TrackballManipulator>
#include <osgUtil/Optimizer>
#include <iostream>
#include <osgEarth/Metrics>
#include <osgEarth/GDAL>
#include <osgEarth/TMS>
#include <iostream>
#include <osgEarthDrivers\sky_simple\SimpleSkyOptions>

using namespace std;
using namespace osgEarth;
using namespace osgEarth::Util;

int main()
{
    osgEarth::initialize();
    //create a viewer
    osgViewer::Viewer viewer;
    viewer.setUpViewInWindow(0, 100, 800, 600);
    viewer.setReleaseContextAtEndOfFrameHint(false);
    //set camera manipulator
    viewer.setCameraManipulator(new EarthManipulator);
    osgEarth::Map* map = new osgEarth::Map();
    //layer
    GDALImageLayer* layer1 = new GDALImageLayer();
    layer1->setURL(osgEarth::URI("E:/osgEarthPro/CustomEarth/CustomEarth/Resources/Layer/world.tif"));
    map->addLayer(layer1);
    //elevation
    TMSElevationLayer* elev2 = new TMSElevationLayer();
    elev2->setURL(osgEarth::URI("http://readymap.org/readymap/tiles/1.0.0/116/"));
    elev2->setVerticalDatum("egm96");
    map->addLayer(elev2);
    osg::ref_ptr<osgEarth::MapNode> mapNode = new osgEarth::MapNode(map);
    osgEarth::SimpleSky::SimpleSkyOptions options;
    options.usePBR() = true;
    osg::ref_ptr<osgEarth::SkyNode> m_skyNode = osgEarth::SkyNode::create(options);
    m_skyNode->setSunVisible(true);
    m_skyNode->setStarsVisible(true);
    m_skyNode->setMoonVisible(true);
    m_skyNode->setLighting(true);
    viewer.setLightingMode(osg::View::SKY_LIGHT);
    m_skyNode->setAtmosphereVisible(true);
    m_skyNode->getSunLight()->setDiffuse(osg::Vec4(10, 10, 10, 1.0));
    m_skyNode->getSunLight()->setAmbient(osg::Vec4(0.5, 0.5, 0.5, 1.0));
    
    osgEarth::DateTime dateTime(2019, 5, 8, 0);
    osgEarth::Util::Ephemeris* ephemeris = new osgEarth::Util::Ephemeris;
    m_skyNode->setEphemeris(ephemeris);
    m_skyNode->setDateTime(dateTime);
   // mapNode->addExtension(Extension::create("sky_simple", options));
    mapNode->addChild(m_skyNode);
    viewer.getCamera()->setClearColor(osg::Vec4(0, 0, 0, 1));
    viewer.setSceneData(mapNode);
    return Metrics::run(viewer);
}

[gwaldron]

You can activate the Eric Bruneton lighting model by calling:
options().useEB() = true;

Your title implies you are getting a crash...?

[luohuiiqng]

Thank you!
It crashes when I use the following code：
mapNode->addExtension(Extension::create("sky_simple", options));
useEB does not exist,Do I need to change the version?
1>D:\hqluo\CTK_OE\QuickTestCode\QuickTestCode.cpp(1403,13): error C2039: "useEB": not "osgEarth::SimpleSky::SimpleSkyOptions" member

[gwaldron]

Maybe - you did not say what version you are using.

[luohuiiqng]

My oe version is 3.2.

[gwaldron]

You will need at least version 3.4 to get the Bruneton lighting model.

Instead of trying to load an extension, just add the SkyNode manually. The SkyNode should be the parent the MapNode in your scene graph:

m_skyNode->addChild(m_mapNode);
viewer.setSceneData(m_skyNode);
m_skyNode->attach(&viewer);

Hope this helps.

[luohuiiqng]

Ok, does 3.4 refer to the osg version?
The latest version of oe appears to be 3.3.

[gwaldron]

The latest release is 3.5:
https://github.com/gwaldron/osgearth/releases/tag/osgearth-3.5

[luohuiiqng]

Thank you!