Filters are applied twice

[danizord]

I have the following query param:

'load_relations' => [
    'location' => 'query',
    'type'     => 'string',
    'required' => false,
    'filters'  => ['json_encode'],
],

So, when I call $client->getCustomers(['load_relations' => ['Contact']); I'd expect Guzzle to send a request with the following query string: ?load_relations=%5B%22Contact%22%5D.
But instead I got: ?load_relations=%22%5B%5C%22Contact%5C%22%5D%22.

That's because Guzzle is filtering the value with json_encode twice:
1 - https://github.com/guzzle/guzzle-services/blob/1.1.0/src/Handler/ValidatedDescriptionHandler.php#L47
2- https://github.com/guzzle/guzzle-services/blob/1.1.0/src/RequestLocation/AbstractLocation.php#L65

[oliverde8]

Hi,

This issue is still present in the 1.1.2 release,

"startDate": {
          "description": "creation date for filtering. Format: 'yyyy-MM-dd'T'HH:mm:ss'",
          "location": "query",
          "sentAs": "start_date",
          "filters" : [
            {
              "method": "date_format",
              "args" : ["@value", "Y-m-d\\TH:i:s\\Z"]
            }
          ]
        },

This will crash because in the ValidationDescriptionHandler the filtering is already done, and later on, the filtering is done again by the Parameters->filter

which caused the fallowing issue

Warning: date_format() expects parameter 1 to be DateTimeInterface, string given  

I am not sure I understand why filtering is done at all at the validation step. Originally my parameter description was :

        "startDate": {
          "type": "object",
          "instanceOf" : "DateTime",
          "description": "creation date for filtering. Format: 'yyyy-MM-dd'T'HH:mm:ss'",
          "location": "query",
          "sentAs": "start_date",
          "filters" : [
            {
              "method": "date_format",
              "args" : ["@value", "Y-m-d\\TH:i:s\\Z"]
            }
          ]
        },

But this creates another error because the filtering is done before the check and therefore I don't have a \DateTime anymore`

[danizord]

Hey @oliverde8, this issue was reintroduced since my PR #135 got reverted by 65ded51. It seems like #145 relies on this behavior :/

[Konafets]

Hi,

the removal introduced a regression or as @danizord mentioned, some folks rely on the odd behavior. I plan to work on that issue and other stuff regarding this package in September again. Stay tuned or provide a PR which takes both issues into account and comes with proper tests :-)

[oliverde8]

Hi,

I will be using 1.1.1 for now as I have limited time on this part of the application and need to finish everything by mid September. I basically upgraded a library that was using guzzle 4, that I couldn't use due to other dependencies requiring guzzle 6.

If i have any time I will look into it for a PR, but I don't think I will have time,

Thanks for you support

[tlorens]

You can just create your own location class that extends AbstractLocation and override the functions that are calling the filters again.