Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for http and non-standard ports #81

Closed
pyhedgehog opened this issue Dec 19, 2016 · 1 comment
Closed

Support for http and non-standard ports #81

pyhedgehog opened this issue Dec 19, 2016 · 1 comment
Assignees
Labels

Comments

@pyhedgehog
Copy link
Contributor

  1. If one starts gitlab (or i.e. gogs) on localhost there are no need for SSL in transfer.
  2. Locally started service can be listening on ports other that 80/443 and 22 for ssh. I.e. gogs by default listens on 3000.

There are several places (at least repo.py:178 where assumed https.

@guyzmo
Copy link
Owner

guyzmo commented Dec 19, 2016

Yup, you're right, I shouldn't have assumed https only per default.

I only introduced recently insecure (i.e. self signed) certificate supports, and it's quite likely that specifiying non-standard ports might break URL lookup. Though there really is only two places where https is assumed, and one of those two where a change is really needed by a PR fixing this issue:

  • it's _guess_repo_slug(), I guess there you could check a service.protocol that would contain https, the same way you can check for service.name etc… That would be doing a proper decoupling of the protocol the same way I've been doing with the other elements.

The other place is:

  • in url_ro which can be overloaded when subclassing the class RepositoryService, so it's less an issue. But still a good idea to keep in coherence with the change I'm suggesting above.

Otherwise, that shouldn't impact the tests, and neither should it impact implementation of the other services.

@guyzmo guyzmo self-assigned this Feb 2, 2017
@guyzmo guyzmo added in progress and removed backlog labels Feb 2, 2017
guyzmo added a commit that referenced this issue Feb 2, 2017
- proxy support (using the gitconfig http configuration)
- custom certificate CA bundle setting
- support of scheme/port settings
- custom SSH URI setup
- and even a setting to define private repository upon creation

kudos to @pyhedgehog to force me into implementing that ☺

Fixes: #107
Fixes: #106
Fixes: #81
Fixes: #88
Signed-off-by: Guyzmo <[email protected]>
guyzmo added a commit that referenced this issue Feb 2, 2017
- proxy support (using the gitconfig http configuration)
- custom certificate CA bundle setting
- support of scheme/port settings
- custom SSH URI setup
- and even a setting to define private repository upon creation

kudos to @pyhedgehog to force me into implementing that ☺

Fixes: #107
Fixes: #106
Fixes: #81
Fixes: #88
Signed-off-by: Guyzmo <[email protected]>
@guyzmo guyzmo added ready and removed in progress labels Feb 2, 2017
@guyzmo guyzmo closed this as completed in 3430cf0 Feb 2, 2017
@guyzmo guyzmo removed the ready label Feb 2, 2017
guyzmo added a commit that referenced this issue Feb 6, 2017
🚧 Features

* Gogs (fixes #18) (kudos @pyhedgehog)
* certificate pinning (fixes #88)
* non-standard http ports (fixes #81)
* possibility to use custom SSH address (fixes #107)
* .gitconfig in XDG home directory (fixes #95)
* .gitconfig's proxy definition support (fixes #105)
* automatically grab PR title/body from last commit (fixes #73)

🚒 Bugfixes

* refactoring of listings, improved list command (fixes #114)

💄 Cosmetics

* Switch to a git tag scheme for versioning (using setuptools-scm)
* Updated README with new informations
* Added @pyhedgehog to contributors
* Updated TODO list

Signed-off-by: Guyzmo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants