Skip to content

docs(#563): add Go concurrent fan-out error handling guidance #571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fullsend-ai-coder wants to merge 1 commit into from
Closed

docs(#563): add Go concurrent fan-out error handling guidance #571

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions AGENTS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,8 @@ When making changes to Go code under `cmd/` or `internal/`:
2. **Vet:** Run `make go-vet` to catch common issues.
3. **E2E tests:** Run `make e2e-test` if your changes touch `internal/appsetup/`, `internal/forge/`, `internal/cli/`, or `internal/layers/`. These tests exercise the full admin install/uninstall flow against a live GitHub org using Playwright browser automation.

**Concurrent error handling:** When Go code fans out goroutines that can fail independently (e.g., WaitGroup + go func patterns), collect all errors into a `[]error` slice protected by a `sync.Mutex` and return `errors.Join(errs...)`. Do not use a single error variable (e.g., `firstErr`) that discards subsequent failures — this hides concurrent errors and forces users into fix-and-rerun cycles. When reviewing PRs, flag single-error-capture in fan-out patterns as a medium-severity finding.

### Running e2e tests

The e2e tests require GitHub credentials. There are three ways to provide them:
Expand Down
Loading