feat: make sandbox creation timeout configurable - #5
Closed
guyoron1 wants to merge 9 commits into
Closed
Conversation
Owner
Author
|
/fs quality |
guyoron1
force-pushed
the
feature/configurable-sandbox-timeout
branch
from
June 14, 2026 08:58
89507e7 to
5c69f03
Compare
Owner
Author
|
/fs quality |
Add resolveTimeout helper that reads duration from environment variables (FULLSEND_SANDBOX_TIMEOUT, FULLSEND_SANDBOX_READY_TIMEOUT) with fallback to the original hardcoded defaults (65s, 60s). Fixes #4
guyoron1
force-pushed
the
feature/configurable-sandbox-timeout
branch
from
June 14, 2026 09:01
5c69f03 to
40709e5
Compare
Owner
Author
|
/fs quality |
QualityFlow Pipeline Summary
Test Output
Issue: GH-4 Generated by QualityFlow |
Owner
Author
|
/fs quality |
1 similar comment
Owner
Author
|
/fs quality |
4 tasks
This was referenced Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make sandbox creation and readiness timeouts configurable via environment variables instead of hardcoded constants.
FULLSEND_SANDBOX_TIMEOUT— overrides the 65s creation timeoutFULLSEND_SANDBOX_READY_TIMEOUT— overrides the 60s readiness timeoutFixes #4
Changes
resolveTimeout()helper ininternal/sandbox/sandbox.godefaultCreateTimeout/defaultReadyTimeoutTest Plan
FULLSEND_SANDBOX_TIMEOUT=120sresolveTimeoutcascade logic