Skip to content

feat: make sandbox creation timeout configurable - #5

Closed
guyoron1 wants to merge 9 commits into
mainfrom
feature/configurable-sandbox-timeout
Closed

feat: make sandbox creation timeout configurable#5
guyoron1 wants to merge 9 commits into
mainfrom
feature/configurable-sandbox-timeout

Conversation

@guyoron1

Copy link
Copy Markdown
Owner

Summary

Make sandbox creation and readiness timeouts configurable via environment variables instead of hardcoded constants.

  • FULLSEND_SANDBOX_TIMEOUT — overrides the 65s creation timeout
  • FULLSEND_SANDBOX_READY_TIMEOUT — overrides the 60s readiness timeout

Fixes #4

Changes

  • Added resolveTimeout() helper in internal/sandbox/sandbox.go
  • Renamed constants to defaultCreateTimeout / defaultReadyTimeout
  • Timeouts cascade: env var > default

Test Plan

  • Verify default behavior unchanged (no env vars set)
  • Verify custom timeout via FULLSEND_SANDBOX_TIMEOUT=120s
  • Verify invalid duration strings fall back to default
  • Unit tests for resolveTimeout cascade logic

@guyoron1

Copy link
Copy Markdown
Owner Author

/fs quality

@guyoron1
guyoron1 force-pushed the feature/configurable-sandbox-timeout branch from 89507e7 to 5c69f03 Compare June 14, 2026 08:58
@guyoron1

Copy link
Copy Markdown
Owner Author

/fs quality

Add resolveTimeout helper that reads duration from environment variables
(FULLSEND_SANDBOX_TIMEOUT, FULLSEND_SANDBOX_READY_TIMEOUT) with fallback
to the original hardcoded defaults (65s, 60s).

Fixes #4
@guyoron1
guyoron1 force-pushed the feature/configurable-sandbox-timeout branch from 5c69f03 to 40709e5 Compare June 14, 2026 09:01
@guyoron1

Copy link
Copy Markdown
Owner Author

/fs quality

@github-actions

github-actions Bot commented Jun 14, 2026

Copy link
Copy Markdown

QualityFlow Pipeline Summary

Stage Agent Status
1 STP Builder
2 STP Reviewer
3 STP Refiner
4 STD Builder
5 STD Reviewer
6 STD Refiner
7 Go Test Generator
8 Python Test Generator

Test Output

Type Count Location
Go/Ginkgo tier 1 3 files qf-tests/GH-4/go/
Python/pytest tier 2 4 files qf-tests/GH-4/python/

Issue: GH-4


Generated by QualityFlow

@guyoron1

Copy link
Copy Markdown
Owner Author

/fs quality

1 similar comment
@guyoron1

Copy link
Copy Markdown
Owner Author

/fs quality

QualityFlow and others added 8 commits June 14, 2026 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add configurable timeout for sandbox creation

1 participant