Skip to content

docs(#371): document agent/skill content migration to fullsend-ai/agents #420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fullsend-ai-coder wants to merge 2 commits into from
Closed

docs(#371): document agent/skill content migration to fullsend-ai/agents #420

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
566073c
docs(#371): document agent/skill content migration to fullsend-ai/agents
fullsend-ai-coder[bot] Jul 12, 2026
8bcd31d
fix(#371): clarify harness README is still actively used
fullsend-ai-coder[bot] Jul 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions AGENTS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,16 @@ The e2e tests require GitHub credentials. There are three ways to provide them:

If only `E2E_GITHUB_USERNAME` and a password source are available, `make e2e-test` will automatically generate a session file before running tests. See `make help` for all available targets.

## Agent definitions and skills

Agent definitions, skills, harness configs, and related content have moved to
[`fullsend-ai/agents`](https://github.com/fullsend-ai/agents). The copies under
`internal/scaffold/fullsend-repo/` are stale and will be removed. Do not modify

@fullsend-ai-review fullsend-ai-review Bot Jul 13, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[medium] internal-consistency

AGENTS.md says 'Do not modify files under internal/scaffold/fullsend-repo/harness/' but the harness/README.md in this same PR says 'changes here remain necessary until the Go references are updated.' The blanket prohibition contradicts the nuanced reality for harness files.

Suggested fix: Differentiate harness from agents/skills in the AGENTS.md guidance: agents/skills should not be modified, but harness changes remain necessary until the Go references (baseurl.go) are migrated.

files under `internal/scaffold/fullsend-repo/agents/`,
`internal/scaffold/fullsend-repo/skills/`, or
`internal/scaffold/fullsend-repo/harness/` — make changes in
`fullsend-ai/agents` instead.

## Forge abstraction

All git forge operations (GitHub API calls, PR comments, issue creation, workflow dispatch, etc.) **must** go through the `forge.Client` interface defined in `internal/forge/forge.go`. This is a fundamental architectural rule — the codebase supports multiple forges (GitHub, GitLab, Forgejo) and direct coupling to any single forge breaks the abstraction.
Expand Down
4 changes: 4 additions & 0 deletions internal/scaffold/fullsend-repo/agents/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
# Deprecated

This content has moved to [`fullsend-ai/agents`](https://github.com/fullsend-ai/agents).
Do not modify files here — they are stale copies and will be removed.

@fullsend-ai-review fullsend-ai-review Bot Jul 13, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[medium] technical-accuracy

README says 'stale copies and will be removed' without noting that Go code actively references agents/ files: scaffold.go lists agents/ in layeredDirs (runtime), scaffold_test.go reads agents/code.md, agents/triage.md, agents/prioritize.md via FullsendRepoFile(), and //go:embed all:fullsend-repo embeds the entire tree. The harness README correctly notes its Go dependency; agents/README.md should do the same.

Suggested fix: Add a note: 'These files are still referenced by Go code (internal/scaffold/scaffold.go, internal/scaffold/scaffold_test.go), so removal requires updating those references first.'

6 changes: 6 additions & 0 deletions internal/scaffold/fullsend-repo/harness/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
# Deprecated

This content is being migrated to [`fullsend-ai/agents`](https://github.com/fullsend-ai/agents).
These files are still embedded by Go code (`internal/scaffold/baseurl.go`), so
changes here remain necessary until the Go references are updated. Once migrated,
these copies will be removed.
4 changes: 4 additions & 0 deletions internal/scaffold/fullsend-repo/skills/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
# Deprecated

This content has moved to [`fullsend-ai/agents`](https://github.com/fullsend-ai/agents).
Do not modify files here — they are stale copies and will be removed.

@fullsend-ai-review fullsend-ai-review Bot Jul 13, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[medium] technical-accuracy

Same issue as agents/README.md: scaffold_test.go reads skills/code-implementation/SKILL.md and skills/issue-labels/SKILL.md via FullsendRepoFile(), and skills/ is listed in layeredDirs. The 'stale copies' claim omits these active Go code dependencies.

Suggested fix: Add a note about Go code references, consistent with the harness README's approach.

Loading