Skip to content

docs(#343): add backlink guidance for new problem docs - #381

Closed
fullsend-ai-coder[bot] wants to merge 1 commit into
mainfrom
agent/343-backlink-guidance
Closed

docs(#343): add backlink guidance for new problem docs#381
fullsend-ai-coder[bot] wants to merge 1 commit into
mainfrom
agent/343-backlink-guidance

Conversation

@fullsend-ai-coder

Copy link
Copy Markdown

Add a bullet to the problem-doc section of AGENTS.md requiring authors to search existing docs for references to their topic and add reciprocal backlinks in the same PR. This codifies the practice demonstrated in PR fullsend-ai#3064, where the maintainer had to manually add backlinks from agent-architecture.md, code-review.md, and autonomy-spectrum.md to a new flapping-convergence.md doc.


Closes #343

Post-script verification

  • Branch is not main/master (agent/343-backlink-guidance)
  • Secret scan passed (gitleaks — a2afa8b179a351845733c680b839a39a82304db6..HEAD)
  • Pre-commit hooks passed (authoritative run on runner)
  • Tests ran inside sandbox

Add a bullet to the problem-doc section of AGENTS.md requiring
authors to search existing docs for references to their topic
and add reciprocal backlinks in the same PR. This codifies the
practice demonstrated in PR fullsend-ai#3064, where the maintainer had to
manually add backlinks from agent-architecture.md,
code-review.md, and autonomy-spectrum.md to a new
flapping-convergence.md doc.

Closes #343
@fullsend-ai-review

fullsend-ai-review Bot commented Jul 12, 2026

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 6:47 AM UTC · Completed 6:53 AM UTC
Commit: a2afa8b · View workflow run →

@fullsend-ai-review

Copy link
Copy Markdown

Review — PR #381

Verdict: ✅ Approve

Summary

This PR adds a single bullet point to the "How to work in this repo" section of AGENTS.md, requiring authors of new problem docs to search existing docs for references to the topic and add reciprocal backlinks in the same PR. The change codifies a practice that was previously handled ad-hoc by maintainers.

Dimensions evaluated

Dimension Result
Correctness ✅ No issues — new guidance is internally consistent with existing AGENTS.md content (complements the "create new file and link from README" rule, mirrors the ADR "same PR" pattern)
Security ✅ No issues — no secrets, no injection patterns, no permission changes
Intent & coherence ✅ Authorized via issue #343 (filed by repo owner). Scope matches exactly. The guardrails concern (bot modifying AGENTS.md) is mitigated: the change adds constraint rather than loosening it, and CODEOWNERS still requires human approval to merge
Style & conventions ✅ Follows existing format — imperative mood, backtick-wrapped paths, logical placement after the "create new file" bullet
Documentation currency ✅ No staleness — referenced path docs/problems/ exists, no conflicts with other docs
Cross-repo contracts ⏭ Skipped — no exported interfaces modified

No findings above the severity threshold.


Protected paths detected — this PR modifies files under one or more
protected paths. The review agent cannot approve PRs that touch these paths.
A human reviewer must approve this PR.

Protected files in this PR:

  • AGENTS.md

Labels: PR modifies AGENTS.md documentation guidance

@fullsend-ai-review fullsend-ai-review Bot added requires-manual-review Review requires human judgment documentation Improvements or additions to documentation labels Jul 12, 2026
@guyoron1

Copy link
Copy Markdown
Owner

/fs-fix

@fullsend-ai-coder

fullsend-ai-coder Bot commented Jul 12, 2026

Copy link
Copy Markdown
Author

🤖 Finished Fix · ✅ Success · Started 8:00 AM UTC · Completed 8:05 AM UTC
Commit: a2afa8b · View workflow run →

@fullsend-ai-coder

Copy link
Copy Markdown
Author

🔧 Fix agent — iteration 1 (human-triggered)

No changes made. The review agent approved this PR with no findings. The human /fs-fix command included no specific instruction. There are no review findings to fix.

Disagreed (1):

  1. no actionable review findings: The review agent approved this PR with verdict 'Approve' and stated 'No findings above the severity threshold.' The review body file is empty. The human triggered /fs-fix without a specific instruction. There are no review findings to address and no human instruction to follow. The PR's single change to AGENTS.md (a protected path) was reviewed and approved by the review agent.

Tests: passed

Updated by fullsend fix agent

@guyoron1 guyoron1 closed this Jul 14, 2026
@guyoron1
guyoron1 deleted the agent/343-backlink-guidance branch July 29, 2026 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation requires-manual-review Review requires human judgment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ARCHIVED] Benchmark issue 343

1 participant