fix(#2305): treat 401/403 comment-posting errors as non-fatal in post-retro.sh - #22
Closed
guyoron1 wants to merge 10 commits into
Closed
fix(#2305): treat 401/403 comment-posting errors as non-fatal in post-retro.sh#22guyoron1 wants to merge 10 commits into
guyoron1 wants to merge 10 commits into
Conversation
…tal in post-retro.sh
The retro post-script previously treated all comment-posting failures as
fatal under set -euo pipefail, causing the entire workflow run to fail
even when the retro agent succeeded and proposal issues were filed. A
403 ("Resource not accessible by integration") is a permanent permission
error — retrying won't help, and the summary comment is informational.
Wrap the gh api comment-posting call in error handling that captures
the exit code and response. If the response contains HTTP 401 or 403,
log a GitHub Actions warning and continue. All other HTTP errors remain
fatal. This prevents permission-gated repos from artificially inflating
the failure rate.
Add post-retro-test.sh with 8 test cases covering: happy path with and
without proposals, 403/401 non-fatal behavior, 500/422 remaining fatal,
and edge cases.
Note: pre-commit could not run in sandbox (shellcheck-py failed to
download due to network restrictions). The post-script runs an
authoritative pre-commit check on the runner.
Closes fullsend-ai#2305
Owner
Author
|
/fs-qf |
Go tier 1: 0 files → qf-tests/FS-2305/go/ Python tier 2: 0 files → qf-tests/FS-2305/python/ [skip ci]
QualityFlow Pipeline Summary
Test Output
Issue: GH-2305 Generated by QualityFlow |
Owner
Author
|
/fs-qf |
9 similar comments
Owner
Author
|
/fs-qf |
Owner
Author
|
/fs-qf |
Owner
Author
|
/fs-qf |
Owner
Author
|
/fs-qf |
Owner
Author
|
/fs-qf |
Owner
Author
|
/fs-qf |
Owner
Author
|
/fs-qf |
Owner
Author
|
/fs-qf |
Owner
Author
|
/fs-qf |
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…_structure, remove related_prs [skip ci]
Replaces intermediate pipeline artifacts with organized test files. Total: 1 test files → qf-tests/fullsend-aiGH-2305/ Jira: fullsend-aiGH-2305 [skip ci]
Owner
Author
|
Closing — QualityFlow test artifacts were inadvertently pushed to this branch. Will re-test on dedicated PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The retro post-script previously treated all comment-posting failures as fatal under set -euo pipefail, causing the entire workflow run to fail even when the retro agent succeeded and proposal issues were filed. A 403 ("Resource not accessible by integration") is a permanent permission error — retrying won't help, and the summary comment is informational.
Wrap the gh api comment-posting call in error handling that captures the exit code and response. If the response contains HTTP 401 or 403, log a GitHub Actions warning and continue. All other HTTP errors remain fatal. This prevents permission-gated repos from artificially inflating the failure rate.
Add post-retro-test.sh with 8 test cases covering: happy path with and without proposals, 403/401 non-fatal behavior, 500/422 remaining fatal, and edge cases.
Note: pre-commit could not run in sandbox (shellcheck-py failed to download due to network restrictions). The post-script runs an authoritative pre-commit check on the runner.
Closes fullsend-ai#2305
Post-script verification
agent/2305-retro-403-non-fatal)f119a205ffb44da8687d9ff1673b6b2d2de2e927..HEAD)