Close remaining gateway multi-connection test gaps from #114#153
Merged
Conversation
#114 closed with GatewayIngress covered only for two concurrent gateways while GatewayEgress got a three-gateway depth test, and the GatewayProvisioningController diff (?since=) path had no cross-gateway isolation test even though the full-fetch path did. - Add StreamTelemetry_ThreeGatewaysConcurrently_NoCrossContamination to GatewayIngressServiceTest, bringing Ingress to the same three-gateway depth as GatewayEgress's Command_RoutesCorrectly_WithThreeConcurrentGateways. - Add Diff_SnapshotIsolatedPerGateway_CrossGatewaySinceFallsBackToFull to GatewayProvisioningControllerTest, verifying the shared IGatewayPointListSnapshotStore correctly scopes diff snapshots by gatewayId (a gateway presenting another gateway's etag as `since` falls back to its own full point list rather than resolving cross-gateway). Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com> Signed-off-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #114 (closed via #115). Re-auditing the four test files that issue touched turned up two remaining depth/coverage gaps within the same scope:
GatewayIngressServiceTest: ゲートウェイgRPC多重接続・ポイントリスト配信のゲートウェイ間分離テスト追加 #114's own gap analysis said Ingress had zero multi-gateway concurrency coverage; the fix landed with a two-gateway test (StreamTelemetry_TwoGatewaysConcurrently_NoCrossContamination), butGatewayEgressgot a three-gateway depth test (Command_RoutesCorrectly_WithThreeConcurrentGateways). AddsStreamTelemetry_ThreeGatewaysConcurrently_NoCrossContaminationto bring Ingress to the same depth as Egress.GatewayProvisioningControllerTest: the full-fetch path has a two-gateway isolation test (Returns200_TwoRegisteredGateways_EachSeesOnlyOwnPoints), but the diff (?since=<etag>) path — which reads from a single sharedIGatewayPointListSnapshotStoreinstance across all gateways in production — had no equivalent isolation test. AddsDiff_SnapshotIsolatedPerGateway_CrossGatewaySinceFallsBackToFull, asserting that one gateway presenting another gateway's (real, retained) etag assincecorrectly falls back to its own full point list instead of resolving against the wrong gateway's snapshot. (Verified by inspection thatMemoryGatewayPointListSnapshotStore's cache key already includesgatewayId— this is a coverage gap, not a live bug — but the isolation now has a test that would go red if that scoping ever regressed.)Both additions strictly follow the existing patterns in each file (same helper methods, same fake/mock setup, same assertion style) — no production code changes.
Test plan
dotnet test --filter "FullyQualifiedName!~IntegrationTest"— could not run locally: this environment's egress policy blocksbuilds.dotnet.microsoft.com(used bydotnet-install.sh), so no .NET SDK is available here. Both new tests were written by strictly mirroring already-passing sibling tests in the same files (same helpers, same fake types, same assertion patterns/overloads) and reviewed carefully for compile-correctness against those exact signatures..NET Build & Testjob inpr-check.yml(fires on every PR, unlike the manual-trigger-onlyoss-ci/integration-tests) will build and run these tests — I'll watch it and fix forward if it flags anything.Checklist
README.md,docs/) if behavior or setup changed — n/a (test-only, no behavior/setup change)Generated by Claude Code