Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for bulk adding files to WIMs #154

Merged
merged 1 commit into from
May 9, 2023
Merged

Conversation

thebookisclosed
Copy link
Collaborator

@thebookisclosed thebookisclosed commented May 9, 2023

Image builder now adds offline setup files to boot.wim in one batch instead of calling WimLib individually for every entry.

Knocks down that part of the build process from ~.5s per file (~1min as of build 23451) to ~1s per whole batch.

Not sure if this follows ideal versioning practices, open to feedback.

Popcorn no longer necessary for building boot.wim
Copy link
Owner

@gus33000 gus33000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me! Versioning is something i'm looking to change up in the future but not now, this for now is perfectly fine. Thanks a lot for this!

@gus33000 gus33000 merged commit 0b2aaa9 into master May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants