Skip to content

ci: move the Bun trial lane and bun-types to 1.4.1 #674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
7nohe merged 2 commits into from
Sep 4, 2026
Merged

ci: move the Bun trial lane and bun-types to 1.4.1 #674

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0160bee
ci: move the Bun trial lane and bun-types to 1.4.1
7nohe Sep 4, 2026
e93d7d1
refactor(server): drop the bun-types 1.4.0 process.off cast
7nohe Sep 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ jobs:
# (scripts/workflow-bun-version.test.ts enforces that); later entries
# are trial lanes for the next Bun line — promote one to first once it
# has soaked.
bun-version: ['1.3.14', '1.4.0']
bun-version: ['1.3.14', '1.4.1']
include:
- bun-version: '1.3.14'
redis: true
Expand Down Expand Up @@ -65,7 +65,7 @@ jobs:
# script is itself `bun run ./scripts/test-packages.ts`), which is
# how the first version of this lane fed the harness a bare
# `--parallel` and died on "Unknown flag".
- bun-version: '1.4.0'
- bun-version: '1.4.1'
redis: true
trial: true
test-bun-flags: '-- -- --parallel --timeout 30000'
Expand Down Expand Up @@ -282,7 +282,7 @@ jobs:
# The flags are applied on pushes only. `--parallel` costs the lane most
# of its green (numbers on the matrix entry above), and a lane that is
# red on two runs in three is one everybody learns to scroll past —
# which would also cost the 1.4.0 promotion soak, the other thing this
# which would also cost the 1.4 promotion soak, the other thing this
# lane is for and the half that passes. On a pull request it therefore
# runs plain, and `--parallel` keeps collecting on main at 11-12 runs a
# day, off everyone's PR checks. The consequence is worth stating: for
Expand Down
4 changes: 2 additions & 2 deletions bun.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@
"@babel/parser": "^7.24.7",
"@babel/types": "^7.29.0",
"@changesets/cli": "^2.31.1",
"bun-types": "^1.4.0",
"bun-types": "^1.4.1",
"oxlint": "1.81.0",
"oxlint-tsgolint": "7.0.2001",
"typescript": "^7.0.2",
Expand Down
10 changes: 3 additions & 7 deletions packages/server/src/http/Application.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,13 +285,9 @@ function registerProcessTeardown(onSignal: () => void, onExit: () => void): () =
process.on('exit', onExit)

return () => {
// Via the EventEmitter surface: bun-types 1.4.0 declares `off` on Process
// with only a "memoryPressure" overload, shadowing the generic `off`, so
// signal names stop compiling. `on`/`once` are unaffected.
const emitter: NodeJS.EventEmitter = process
emitter.off('SIGINT', onSignal)
emitter.off('SIGTERM', onSignal)
emitter.off('exit', onExit)
process.off('SIGINT', onSignal)
process.off('SIGTERM', onSignal)
process.off('exit', onExit)
}
}

Expand Down
Loading