Skip to content

Correct Vertex global region endpoint URL construction #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gunpal5 merged 1 commit into from
Oct 25, 2025
Merged

Correct Vertex global region endpoint URL construction #84

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/GenerativeAI/Platforms/VertextPlatformAdapter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,7 +328,7 @@
/// <param name="appendLocation">Indicates whether to include the location/region in the URL.</param>
/// <param name="appendProject">Indicates whether to include the project ID in the URL.</param>
/// <returns>The constructed base URL string.</returns>
public string GetBaseUrl(bool appendVersion = true, bool appendPublisher = true, bool appendLocation = true,

Check warning on line 331 in src/GenerativeAI/Platforms/VertextPlatformAdapter.cs

View workflow job for this annotation

GitHub Actions / build (9.0.x) 

In member string VertextPlatformAdapter.GetBaseUrl(bool appendVersion = true, bool appendPublisher = true, bool appendLocation = true, bool appendProject = true), change parameter name appendVersion to appendVesion in order to match the identifier as it has been declared in string IPlatformAdapter.GetBaseUrl(bool appendVesion = true, bool appendPublisher = true, bool appendLocation = true, bool appendProject = true) (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1725)
bool appendProject = true)
{
if (ExpressMode == true)
Expand All @@ -342,7 +342,7 @@
}

// Start with base domain
string baseUrl = $"https://{Region}-aiplatform.googleapis.com";
var baseUrl = Region == "global" ? "https://aiplatform.googleapis.com" : $"https://{Region}-aiplatform.googleapis.com";

// Append version: /{version}
if (appendVersion)
Expand Down
Loading