-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CalculateAverage_ebarlas submission. #22
Conversation
Nice, thanks a lot! Will evaluate it tomorrow. What's the difference
between this one and the baseline on your machine?
… Message ID: ***@***.***>
|
On a Reference:
Mine:
|
Very cool, looks like a top contender :)
… Message ID: ***@***.***>
|
Thanks! I'm eager to see how it measures up! I haven't done any micro-optimizations yet. I assume I can simply open subsequent PRs with additional changes? |
Yepp, absolutely. You can send follow-up PRs until the challenge closes
(Jan 31).
… Message ID: ***@***.***>
|
…ups. Use ByteBuffer.get(int, byte[], int, int) method. Add more clarifying comments.
Updated exec time after addition optimizations:
|
Hey, could you run |
Sure, looking now... |
Done. How does that look now? |
This looks great! 2nd place right now with 00:16.558 after @spullara! Worth trying how yours fares with GraalVM, too, I suppose. |
Shamelessly sharing this idea for JVM/GC tuning in another PR/discussion? #15 (comment) |
@gunnarmorling, silly question: how can I request execution with GraalVM CE? I just re-ran in my test environment and it is indeed noticeably faster there. I don't see any metadata or env setup indicating GraalVM by @spullara. |
@ebarlas, please specify the JDK in the submission PR (see README). Indeed this wasn't the case for @spullara explicitly, but I read between the lines that this is what he tested with so I interpreted this as to use GraalVM. So just create a new PR for if you'd like to do that. Better yet: could you try whether adding |
Okay, thanks! |
I created a separate PR with a request to run with GraalVM. Includes SDKMAN command. |
No description provided.