Repository navigation
MachineShape construction wall may be dormant: test.claim.machine_shape_construction_wall matches no required_gate_prefixes entry, so its RED/GREEN controls may never execute on the required path - #9823
Merged
Conversation
briansrls
pushed a commit
that referenced
this pull request
Aug 31, 2026
…the lines git happened to print (#9829) The changed-witness sublane selected ONE of the two sibling test fns in the MachineShape construction wall that #9823 renamed into the required floor, and the one it missed was the wall's discriminating RED. The wall itself was fine: run 33413900349's own disposition receipt carries `gate_red_synthetic_machine_shape_call` as `planned` / `passed`. It executed via the ordinary Planned arm and only the projection line was absent. The selection was not fine. `parse_unified_diff_added_paths` already rules that a `rename to` destination is new-at-path -- "its declaration set is established fresh at NEW" -- but that ruling only ever lifted the line-1 fail-closed refusal. Nothing acted on the declaration set, so a moved file's identities were attributed by which lines the move happened to edit. For a `/dev/null` add the two agreed by accident (every line is a `+` line); for a rename they do not. Measured over the 90 commits reachable from HEAD: 8 of 8 rename-destination `.dag` files carrying test decls were under-enrolled, 87 of 103 identities missed. A pure move with no content edit enrolls NOTHING. It mattered beyond the projection line because changed-witness membership is what OVERRIDES the cost-debt withhold and the outside-gate suppression, so the same miss on a rostered identity is a silent decline of a witness whose author is present -- the state v2.workflow.floor_changed_witness exists for. The universe of the fix is the file's own parsed decl list, never the corpus: the precise answer to "what does this path declare", not an absorbing widen (DESIGN section 5). No refusal arm changed. Two controls, run remote in release, in both directions: rename_destination_enrolls_every_test_decl_not_only_the_diff_touched_one feeds #9823's verbatim `git diff -U0` output and asserts enrolled == declared. Fix disabled: FAILS. Proven, not asserted. in_place_modify_enrolls_only_the_touched_test_decl passes under both states, so the first test's red is discriminating rather than a build break, and the fix cannot be satisfied by widening. Claude-Session: https://claude.ai/code/session_018aiTywconE9bm1hmUPjyft Co-authored-by: Brian Searls <briansearls1@gmail.com> Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto-opened by session-dashboard for session
quick-eagle-249.Pushing to
session/quick-eagle-249advances this PR.Worker attestation
Before flipping this PR to ready for review, confirm each item:
npm test,cargo test) and the result.Closes #Ndirective.Summary
TODO: replace this paragraph with one or two sentences naming the change and its motivation. Reviewers read this first.
Test plan