Repository navigation
Repair the three remaining floor-band refusals #9608 exposed: two source defects and one frontier-row key written in the renderer's old spelling - #9658
Closed
gunbai-bot[bot] wants to merge 2 commits into
Conversation
…nd its shape rendering: repair two at the source, re-key the spine's frontier row to the shape the renderer now spells - pid_control_program: curve_points_agree compared ZoneDemandValue through the Measure comparator; ZoneDemandValue is deliberately not a Measure, so it gets its own agreement fn over the same exact_decimal_equal rule. - fabric_terminal_contract witness: the positive control's receipt was the one inline literal in the file, so P inferred String against the grant's NonEmptyStr; hoisted to an annotated data like every sibling. - unresolved_method_frontier: the spine row's key was measured before #9608 added the Node(name<args>) arm to node_type_shape; identical receiver, new spelling. Re-keyed to the observed shape, which narrows the admission. Attribution by run bisection and #9608's own diff, recorded on the row. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KH3G4UzMgvQobyNgHYy4GU
…ain's side, branch carries no delta
Contributor
Author
|
Superseded: main landed independent fixes for all three subjects while this was in review — #9655 hoisted the fabric receipt (same shape, same fixture name), the pid comparator was fixed inline on Two live notes for whoever picks main up next:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main's required floor has refused at strict-preparation since
fb9fa04e2(#9608) landed. #9645/#9646/#9650 closed most of the diagnostic set; this closes the remaining three subjects (five diagnostics), which are all latent defects that commit's new walls exposed, not regressions in the touched files. Attribution is by run bisection — the parent commit's floor executed (run 33198301968), #9608's run refused with exactly this diagnostic set (run 33198310614) — and by #9608's own diff.1.
dag/extdeps/bmc/pid_control_program.dag:322—curve_points_agreecomparedDemandCurvePoint.outputthroughdecimal_measures_agree, whose parameters areMeasure<Q,S,ExactDecimal>.ZoneDemandValueis deliberately not a Measure (its own comment: the zone's output units are not fixed by the schema). The new direct-call inhabitance wall refused it. Fix: a peerzone_demand_values_agreeover the sameexact_decimal_equalrule, on the carrier that holds the value.2.
dag/test/claim/fabric/fabric_terminal_contract_witness_test.dag— the positive control's receipt was the one inlineReceiptliteral in the file, soPinferredStringfrom the bare principal literal againstfixture_grant: ExecutionGrant<NonEmptyStr>. Hoisted to an annotateddatalike every sibling receipt.3.
src/v1/04_infer.dagunresolved_method_frontier— thegunbc.source_integration_landing_spinerow's key was measured whennode_type_shapehad no arm for a named node with children, so the receiver rendered as bareNode(Optional). #9608 added theNode(name<args>)arm; the identical receiver now rendersNode(Optional<Primitive(LandingNormativeOption)>), the equality dropped observed to zero against declared one, and both ratchet directions fired. The site is exactly as unresolved as when the row was measured — only the spelling changed — so the row is re-keyed, not deleted, and the re-key narrows the admission (an unresolvedmapon an Optional of any other payload now refuses). The bisection receipt is recorded on the row'scause. The committed stage0 mirror carries the identical edit for regen convergence. v1-band touch is under the operator's v2-self-host admission test: this repairs the required floor that gates everything.Verification, by execution (remote, compiler built from this tree): entry-scoped
gunbc compile --entryon each subject — pid rc=0 / 0 hard errors, fabric rc=0 / 0, spine rc=0 with 541:9 now the counted advisoryMethodExistenceFrontierAdmitted; clean controlextdeps/vendor/arm.dagrc=0. The pre-fix tree refused on all three under the same instrument, so the instrument discriminates.Floor caveat: the floor refuses on the whole diagnostic set, so whatever the fold itself finds once preparation clears is still unmeasured — this PR unblocks preparation, it does not promise a green fold.
🤖 Generated with Claude Code
https://claude.ai/code/session_01KH3G4UzMgvQobyNgHYy4GU