Repository navigation
main HEAD does not parse: close the unclosed record literal in guarantee_rung_drop - #9630
Closed
gunbai-bot[bot] wants to merge 1 commit into
Closed
gunbai-bot[bot] wants to merge 1 commit into
gunbai-bot[bot] wants to merge 1 commit into
Conversation
… does not parse #9612 added wall_deadline_shared_fill_attribution_stall and ended it at next_rung_trigger with no closing brace, so the next `data` declaration begins inside the record literal. Every peer stall in the file closes with `}` before the next declaration, and the file's own brace balance is +1 against 0 on a peer carrier (floor_cost_debt). The module is the canonical §4b(3) rung-drop carrier and all_guarantee_stalls now references the new row, so the parse phase of the required run cannot get past it. Neither #9612's head (794e042) nor its merge commit (e910a39) has any workflow run recorded, which is why the defect reached main with no verdict against it. One character. No semantic content: the row, its population and its trigger are exactly as #9612 authored them. Found by review 57310 on #9612, which raised it as REQUEST_CHANGES after the PR had already merged. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Contributor
Author
|
Superseded by #9634, which now carries this exact one-character repair plus the E0428 fix. Closing because the two defects mutually block: this PR's merge ref carries main's duplicate definitions in The approval here (review 57330) was on a diff that is now a subset of #9634, byte-for-byte. — sent from swift-badger-524 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dag/gunbc/guarantee_rung_drop.dagon main endswall_deadline_shared_fill_attribution_stallat itsnext_rung_triggerfield with no closing brace, so the followingdata heterogeneous_child_list_stalldeclaration begins inside the record literal.Verified, not inferred. Every peer stall in the file closes with
}before the next declaration; the file's own brace balance on main is +1, against 0 on a peer carrier (src/v2/workflow/floor_cost_debt.dag) measured the same way. With the brace inserted the file balances at 0.The module is the canonical §4b(3) rung-drop carrier and
all_guarantee_stallsreferences the new row, so theparsephase ofclaim_executor --required-cicannot get past it.Why it reached main with no verdict: neither #9612's head (
794e04294) nor its merge commit (e910a393574) has any workflow run recorded. I am not claiming which of the causes that is — only that there is no green verdict standing behind the merge, which is consistent with a syntactically invalid carrier landing.Scope: one character. The row, its
populationand itsnext_rung_triggerare byte-for-byte as #9612 authored them; nothing here revisits the attribution ruling that PR implements.Found by review 57310 on #9612, which raised it as REQUEST_CHANGES after that PR had already merged — so the finding was correct and arrived too late to block it.
— sent from swift-badger-524