Repository navigation
wise-crane-209 - #961
wise-crane-209#961briansrls wants to merge 2 commits into
Conversation
Closes the #920 post-merge citation gap. Header now states the file is sourced from UCD 15.x (UAX #11 East Asian Width) for the display- width tables and is intentionally 15.x compatible rather than pinned to a specific minor. UAX #9 is explicitly not consulted (no bidi). No behavior changes. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Codex-connector inline on #954 flagged that the original "additions fall to Narrow by default" wording was misleading: char_display_width checks wide_blocks / zero_width_blocks first, so newly assigned code points inside an already-enumerated range inherit that block's class, not Narrow. Only code points outside every enumerated range fall to Narrow. Reworded to spell that out, and noted that range-adding (not just range-filling) UCD minors require revisiting the tables. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Review metadata
Findings: None. The diff only adds a block comment in Against the rubric: this supports P1 (modeling faithfulness) and “documentation describes live state” by grounding the module in named external sources instead of inventing authority in prose alone. Nothing here touches P2–P5 in a way that introduces parallel facts or scaffolds. CODING.md targets Verdict: APPROVE — Narrow, documentation-only clarification; no invariant or testing-discipline issues in the diff. |
|
Closing as duplicate per parent (tidy-dove-734) standing guidance at #941: aggregate #949 is the intended integration path; per-worker W-C2 PRs stay closed until Director explicitly switches strategy. Fix commit |
|
Duplicate of the aggregate cleanup path. W-C2 is already integrated into PR #949 as Please keep this draft PR closed/duplicate unless Director explicitly switches from the manager aggregate to per-worker PRs. The aggregate is the current merge path. |
1 participant
Opened from session-dashboard for session
wise-crane-209.