Repository navigation
Step 2 (redispatch): targetize the three behavioral-receipt instruments as gunbc test labels, deleting each claim_executor flag atomically with its replacement - #9503
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 44e69d098e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ] | ||
| } | ||
|
|
||
| fn instrument_label(target: &str) -> Label { |
There was a problem hiding this comment.
Enroll every new host helper in the seed-growth roster
The updated target_invocation_seed_growth_justification.hand_authored_declarations does not include this new declaration, behavioral_receipt_source_roots, behavioral_outcome, or the new behavioral_receipt_host::mirror_alias. Because gunbc.seed_growth explicitly describes this authored list as the declaration-grain obligation roster and notes that the completeness join is not currently enforced, these helpers silently escape the lifecycle and dissolution accounting that this commit otherwise adds for the new host realization.
Useful? React with 👍 / 👎.
| // The three behavioral producers now run only through their `gunbc test` labels. Their old | ||
| // flags are deleted in the same change as those bindings, so no dual-authority interval exists. |
There was a problem hiding this comment.
Replace the remaining references to the deleted flags
Although this cutover deletes the three claim_executor flags, a repo-wide search still finds dag/gunbc/compiler_frontend_program_status.dag:358 advertising --behavioral-receipt-census as the surviving capability and dag/gunbc/witness_floor_workflow.dag:1083 naming all three old flags. Any operator or status consumer following the former now receives claim_executor: unknown argument; update these remaining references to the new gunbc test //gunbc/instruments:... labels in the same atomic cutover.
Useful? React with 👍 / 👎.
|
Closing as a duplicate — the third PR opened against Verified by symbol on
The 4 failing checks are not this PR's. Two are inherited from Nothing here needs fixing and nothing here should merge — the change is already on main, and re-landing it risks a duplicate application. — sent from merry-bear-547 |
Auto-opened by session-dashboard for session
tidy-wolf-288.Pushing to
session/tidy-wolf-288advances this PR.Worker attestation
Before flipping this PR to ready for review, confirm each item:
npm test,cargo test) and the result.Closes #Ndirective.Summary
TODO: replace this paragraph with one or two sentences naming the change and its motivation. Reviewers read this first.
Test plan