Skip to content

Step 2 (redispatch): targetize the three behavioral-receipt instruments as gunbc test labels, deleting each claim_executor flag atomically with its replacement - #9503

Closed
briansrls wants to merge 10 commits into
mainfrom
session/tidy-wolf-288
Closed

briansrls wants to merge 10 commits into
mainfrom
session/tidy-wolf-288

Conversation

@briansrls

Copy link
Copy Markdown
Contributor

Auto-opened by session-dashboard for session tidy-wolf-288.
Pushing to session/tidy-wolf-288 advances this PR.

Worker attestation

Before flipping this PR to ready for review, confirm each item:

  • Title describes the change (not the session id or branch).
  • PR body summarises what and why (replace the TODO below).
  • Tests run: name the command (e.g. npm test, cargo test) and the result.
  • If this closes a work item, the body contains a Closes #N directive.
  • No commits on this branch are surprises (no fork/cherry-pick I did not make).
  • No secrets / credentials / large binaries staged.

Summary

TODO: replace this paragraph with one or two sentences naming the change and its motivation. Reviewers read this first.

Test plan

  • TODO: list the commands that ran (or "no tests changed; relied on CI") and the outcome.

@briansrls
briansrls marked this pull request as ready for review August 27, 2026 18:50

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 44e69d098e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

]
}

fn instrument_label(target: &str) -> Label {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Enroll every new host helper in the seed-growth roster

The updated target_invocation_seed_growth_justification.hand_authored_declarations does not include this new declaration, behavioral_receipt_source_roots, behavioral_outcome, or the new behavioral_receipt_host::mirror_alias. Because gunbc.seed_growth explicitly describes this authored list as the declaration-grain obligation roster and notes that the completeness join is not currently enforced, these helpers silently escape the lifecycle and dissolution accounting that this commit otherwise adds for the new host realization.

Useful? React with 👍 / 👎.

Comment on lines +346 to +347
// The three behavioral producers now run only through their `gunbc test` labels. Their old
// flags are deleted in the same change as those bindings, so no dual-authority interval exists.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Replace the remaining references to the deleted flags

Although this cutover deletes the three claim_executor flags, a repo-wide search still finds dag/gunbc/compiler_frontend_program_status.dag:358 advertising --behavioral-receipt-census as the surviving capability and dag/gunbc/witness_floor_workflow.dag:1083 naming all three old flags. Any operator or status consumer following the former now receives claim_executor: unknown argument; update these remaining references to the new gunbc test //gunbc/instruments:... labels in the same atomic cutover.

Useful? React with 👍 / 👎.

@gunbai-bot

gunbai-bot Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Closing as a duplicate — the third PR opened against session/tidy-wolf-288 at head 44e69d098, whose work merged as f820985cc (#9427) at 16:56. #9479 was the second and was closed for the same reason.

Verified by symbol on main rather than by ancestry, because squash-merge makes 44e69d098 correctly not an ancestor:

  • src/v1/stage0/src/behavioral_receipt_host.rs — present
  • --behavioral-receipt-* flags in claim_executor.rs — 0 remaining

The 4 failing checks are not this PR's. Two are inherited from main, which is currently red for every open PR — dag/product/fabric/contention.dag imports grant_duration_seconds, which product.fabric.supply stopped declaring in b20ac7ad44f. #9488 is the fix and is open. The rest follow from this head predating the product.fabric.supply changes its contention consumers need.

Nothing here needs fixing and nothing here should merge — the change is already on main, and re-landing it risks a duplicate application.

— sent from merry-bear-547

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant