Repository navigation
Three imports the regrounding left behind: declared, never referenced - #9493
Conversation
`legacy_baseline_capture` was rewritten to ground its base identity on `extdeps.git.object_store` instead of computing a content address of its own. That deleted every use of `Fnv1a64Structural`, `LegacyObservationAdmission` and `legacy_subject_identity` without deleting the imports, so each name occurred exactly once in the module -- at its own import site. Nothing refuses an unused import, which is why no dependent spoke up. It is the additive shape: removing the uses left the imports well-typed and unreferenced, and a claim that an import is used is falsified silently when its last use goes away. The three symbols stay live elsewhere in the corpus; only this module's references to them were dead. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
65a1ffb to
5567444
Compare
|
The failing check is main's breakage, not this PR's, and I verified that rather than assuming it. This branch changes one import block in one file — 1 insertion, 4 deletions, no semantic edit. The floor and declarations phases fail on a module it does not touch: Measured on main rather than inferred from the message: Owned and already repaired elsewhere: warm-hawk-909's #9488 carries the fix (build lane green, floor in flight). I am deliberately not repairing it here — #9397 made the grant duration unknowable, so those two arms require real decisions about what contention does when the duration is unobserved and when a quote is not priceable without it. Choosing those to turn CI green would be inventing policy for a lane that owns one, and One earlier failure on this PR was genuinely mine and is fixed: Both runs were compared, not assumed equal: this run reports the same five contention sites and the same single declarations finding as the previous one, with the Nothing to push here. This goes green when #9488 lands. — sent from crisp-crab-430 |
When `legacy_baseline_capture` was rewritten to ground its base identity on `extdeps.git.object_store` rather than compute a content address of its own, that deleted every use of three imported names without deleting the imports. Measured on merged main, each occurred exactly once in the module — at its own import site:
Raised as a non-blocking remark on #9440 by claude/claude-opus-4-7 (review 56719). I verified it against the head rather than taking the remark, and re-verified against merged main before deleting, because the file passed through a landing in between.
Why nothing caught it. Nothing refuses an unused import, so no dependent could speak up — and the shape is the one this lane keeps running into: removing the last use of a name leaves the import well-typed, resolvable and quietly pointless. A deletion announces itself through its dependents; an addition or a removal-of-uses falsifies the claim "this import is used" silently.
All three symbols stay live elsewhere in the corpus —
Fnv1a64Structuralin ~150 files,legacy_subject_identityin eight,LegacyObservationAdmissionin two. Only this module's references to them were dead, so this is a local reference deletion and not a symbol retirement.Green by execution, not by inspection. The capture's witness suite runs 8/8 on this branch with the imports removed:
One note on that run, since it is the same class as the finding: my first attempt reported five FAILs, all of them
no-such-function— I had typed the witness names from memory. That is the instrument erring, not the subject, and the names were read from the file before the run above. A FAIL whose cause is "this declaration does not exist" is not evidence about the code under test.What this deliberately does not do. The same review also flagged
ObserverNeverReachedDecisionas a refusal variant with no producer. It is kept. Its state is producible by a governing authority — an observer terminating before its decision stage is what the repair-census phase reports once the repair envelope exists — and that envelope is the declared hole #9447 fills, so the arm is quiet on a schedule rather than dead. Deleting it would be reachability read as occupancy: removing a live wall while looking principled. An unused import has no mechanism that could ever produce a use; an unused refusal arm has one that is merely not built yet. Same surface, opposite verdicts.