Repository navigation
Replace hostile-writer shell scaffold with typed host effect - #9363
Merged
Merged
Conversation
Contributor
|
Fixed the fail-closed transport defect identified by review 56394 in commit 5de90f8.
I also added an executing witness using — sent from neat-tern-474 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is the operator-directed dissolution of the population admitted in #9341, not a claim that its merge was unauthorized. It:
ProbeToolchainHomeInterferenceas a typed runner-localHostEffectand realizes it throughhost_effect_applyRunnerLocalHostinstead of fabricating a fleetComputeHostThe three older
unbound_dissolutionrows still inci_workflow_run_emit.dag(toolchain_home_isolation,pin_rustup_default, andnative_cache_root) predate #9341 and are outside this dissolution.v1 seed admission
This change touches
v1_interpreter.rs,v1_compiler_infer_method.rs,v1_interpreter_dispatch_generated.rs, and04_method.dag. The v1 seed remains frozen for growth. This change is admitted by the PURPOSE test ingunbc.v1_maintenance_standing.v1_seed_standing: it serves the v2 self-host program by providing the native realization required for a typed v2host_effect_applyarm, allowing the rejected shell scaffold to be deleted. It adds no v1 capability for v1's own sake; v1 is the shrinking bootstrap realization beneath the modeled v2 effect.Net hand-Rust receipt
Measured with
git diff --numstat origin/main...HEAD -- '*.rs', the Rust delta is +172/-0 LOC: +164 in the hand-maintained existing filev1_interpreter.rs, plus +5 in the generatedv1_compiler_infer_method.rsmirror and +3 in the generated interpreter-dispatch mirror. Therefore the net hand-Rust surface is larger by 164 LOC, in zero new Rust files.The hand-maintained declaration delta is four functions, all in
v1_interpreter.rs: two projections that construct the modeled result/refusal values, the builtin realization, and its nested concurrent fixture arm. The existing builtin dispatch gains one modeled-roster arm. Each exists solely to make the typed v2 host effect executable; none adds a v1-facing feature. The deleted scaffold is 170 lines of.dag/generated workflow shell, so it is real shell-to-intent migration but not a net-negative hand-Rust claim—the currencies are reported separately.State-space repair
The result type deliberately keeps four named refusal states:
ToolchainPrivateHomeBindingMissing: harness configuration is absent or wrongToolchainSharedArmDidNotObserveInterference: the positive control did not demonstrate interferenceToolchainPrivateHomeIsolationBreached: the defect the discriminator exists to detectToolchainInterferenceFixtureFailed: the fixture itself could not executeThis is a state-space fix, not message wording. In particular, missing
CARGO_HOMEbinding and a real isolation breach require opposite remedies and must not share one status symbol again.Verification
cargo fmt --all --check(pre-commit and pre-push)cargo check -p v1-compiler --bin gunbcCARGO_HOME=$RUNNER_TEMP/cargoToolchainPrivateHomeBindingMissingThe interference arms were mutated and restored one at a time:
/bin/falseto/bin/true; the probe failed alone withToolchainSharedArmDidNotObserveInterference. Restored/bin/falsebefore the next mutation.ToolchainPrivateHomeIsolationBreached. Restored the separate legacy path afterward.