Skip to content

Delete the plan/walk surface nothing could reach (claim_executor 21,366 -> 11,508) #9228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
briansrls merged 7 commits into from
Aug 25, 2026
Merged

Delete the plan/walk surface nothing could reach (claim_executor 21,366 -> 11,508) #9228

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
502e3e5
Delete the plan/walk surface nothing could reach, and the 27 cli_run …
Aug 25, 2026
6314b9d
Delete the five empty impl stubs the method deletion left behind
Aug 25, 2026
5f3361a
Delete corpus-type-judgment at the root: mode, workflow, emitter and …
Aug 25, 2026
8c7eaca
Delete the 542 tests whose subjects this branch deleted, and the four…
Aug 25, 2026
bda1331
Delete the second argv reader: the coordinator was reachable the whol…
Aug 25, 2026
e191871
Drop the four imports the coordinator cut orphaned; CI builds with -D…
Aug 25, 2026
184a056
Merge main: picks up #9205's infer_semantics_witness TypeEnv fix, whi…
Aug 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .gitattributes
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
.githooks/generated-artifact-merge merge=generated-artifact
.githooks/pre-commit merge=generated-artifact
.githooks/pre-push merge=generated-artifact
.github/workflows/corpus-type-judgment.yml merge=generated-artifact
.github/workflows/fleet-converge.yml merge=generated-artifact
.github/workflows/fleet-desired.yml merge=generated-artifact
.github/workflows/witnesses.yml merge=generated-artifact
Expand Down
28 changes: 0 additions & 28 deletions .github/workflows/corpus-type-judgment.yml
View file
Open in desktop

This file was deleted.

6 changes: 3 additions & 3 deletions dag/gunbc/claim_executor_cli.dag
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@ import extdeps.exec.command { ArgvCommand, argv_command }
// claim_executor is built from this tree, so its flags are a fact this repository already owns
// rather than an upstream contract to cite. It is homed under gunbc/ for exactly that reason.
//
// WHY IT EXISTS: two workflow emitters -- gunbc.fabric_witness_run and
// gunbc.corpus_type_judgment_workflow -- each hand-spelled the path and the mode flag into their own
// argv, so "where the release binary lives" was two facts that happened to agree. The path is
// WHY IT EXISTS: two workflow emitters -- gunbc.fabric_witness_run and a peer since deleted --
// each hand-spelled the path and the mode flag into their own argv, so "where the release binary
// lives" was two facts that happened to agree. The path is
// relative because it names a build output inside the checkout the job is standing in, not an
// installed program; that is a real difference from every extdeps tool row, whose absolute paths
// exist because a sudoers rule or an ambient PATH would otherwise decide which binary ran.
Expand Down
286 changes: 0 additions & 286 deletions dag/gunbc/corpus_type_judgment_workflow.dag
View file
Open in desktop

This file was deleted.

6 changes: 1 addition & 5 deletions dag/gunbc/generated_artifact.dag
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ import gunbc.generated_artifact_merge_driver { generated_artifact_merge_driver_s

type GeneratedArtifact
= WitnessFloorYamlArtifact
| CorpusTypeJudgmentYamlArtifact
| FleetConvergeYamlArtifact
| FleetDesiredAdmissionYamlArtifact
| GitignoreArtifact
Expand All @@ -30,7 +29,7 @@ type GeneratedArtifact
data generated_artifact_registry: List<GeneratedArtifact> = concat(
concat(
concat(
[WitnessFloorYamlArtifact, CorpusTypeJudgmentYamlArtifact, FleetConvergeYamlArtifact, FleetDesiredAdmissionYamlArtifact, GitignoreArtifact, GitattributesArtifact, RoadmapArtifact, DesignArtifact, GithooksPrePushArtifact, GithooksPreCommitArtifact, GeneratedArtifactMergeDriverArtifact, RunnerDeployArtifact, Stage0CrateLayoutGeneratedDagArtifact, Stage0CrateLayoutGeneratedRsArtifact, Stage0CratePartitionGeneratedDagArtifact, V1InterpreterDispatchGeneratedRsArtifact],
[WitnessFloorYamlArtifact, FleetConvergeYamlArtifact, FleetDesiredAdmissionYamlArtifact, GitignoreArtifact, GitattributesArtifact, RoadmapArtifact, DesignArtifact, GithooksPrePushArtifact, GithooksPreCommitArtifact, GeneratedArtifactMergeDriverArtifact, RunnerDeployArtifact, Stage0CrateLayoutGeneratedDagArtifact, Stage0CrateLayoutGeneratedRsArtifact, Stage0CratePartitionGeneratedDagArtifact, V1InterpreterDispatchGeneratedRsArtifact],
map(fleet_autoinstall_specs, s => AutoinstallUserDataArtifact { spec: s })
),
map(fleet_install_server_specs, s => ProxyDhcpDnsmasqArtifact { spec: s })
Expand All @@ -51,7 +50,6 @@ type CommitPolicy
fn artifact_path(a: GeneratedArtifact) -> String {
match a {
WitnessFloorYamlArtifact => ".github/workflows/witnesses.yml"
CorpusTypeJudgmentYamlArtifact => ".github/workflows/corpus-type-judgment.yml"
FleetConvergeYamlArtifact => ".github/workflows/fleet-converge.yml"
FleetDesiredAdmissionYamlArtifact => ".github/workflows/fleet-desired.yml"
GitignoreArtifact => ".gitignore"
Expand Down Expand Up @@ -80,7 +78,6 @@ fn artifact_commit_policy(a: GeneratedArtifact) -> CommitPolicy {
GithooksPreCommitArtifact => CommitRequired { consumer: GitProtocol }
GeneratedArtifactMergeDriverArtifact => CommitRequired { consumer: GitProtocol }
WitnessFloorYamlArtifact => CommitRequired { consumer: GithubActionsWorkflow }
CorpusTypeJudgmentYamlArtifact => CommitRequired { consumer: GithubActionsWorkflow }
FleetConvergeYamlArtifact => CommitRequired { consumer: GithubActionsWorkflow }
FleetDesiredAdmissionYamlArtifact => CommitRequired { consumer: GithubActionsWorkflow }
RoadmapArtifact => CommitRequired { consumer: ProjectDocumentation }
Expand Down Expand Up @@ -116,7 +113,6 @@ data artifact_eq_disposition_reference_note: String = "Disposition authority (re
fn artifact_eq(a: GeneratedArtifact, b: GeneratedArtifact) -> Bool {
match a {
WitnessFloorYamlArtifact => match b { WitnessFloorYamlArtifact => true _ => false }
CorpusTypeJudgmentYamlArtifact => match b { CorpusTypeJudgmentYamlArtifact => true _ => false }
FleetConvergeYamlArtifact => match b { FleetConvergeYamlArtifact => true _ => false }
FleetDesiredAdmissionYamlArtifact => match b { FleetDesiredAdmissionYamlArtifact => true _ => false }
GitignoreArtifact => match b { GitignoreArtifact => true _ => false }
Expand Down
Loading
Loading