Skip to content

Stop the srv4 activation witness rendering a refusal as an empty string #9054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
briansrls merged 2 commits into from
Aug 24, 2026
Merged

Stop the srv4 activation witness rendering a refusal as an empty string #9054

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eb97077
Stop the srv4 activation witness rendering a refusal as an empty string
Aug 23, 2026
080c38f
Merge main: pick up #9027's annotation repair so CI evaluates a curre…
Aug 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 24 additions & 22 deletions dag/test/claim/runner_host_deploy_witness_test.dag
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,29 +107,31 @@ test fn srv4_runner_app_from_secret_manager() -> Bool {
// discriminating, and a command that listed the units without the verb still fails here.
test fn srv4_enables_its_declared_runner_instances() -> Bool {
let names = runner_instance_names(deploy: srv4_runner_host_deploy)
let enable = match runner_activate_command(admission: admit_runner_activation(host_admission: admit_runner_host(deploy: srv4_runner_host_deploy), cache_ready: witness_ready_receipt(), pool_ready: witness_ready_pool())) {
RunnerCommandReady { command: cmd } => shell_command_render(command: cmd)
RunnerCommandRefused { host_label: _, reason: _ } => ""
match runner_activate_command(admission: admit_runner_activation(host_admission: admit_runner_host(deploy: srv4_runner_host_deploy), cache_ready: witness_ready_receipt(), pool_ready: witness_ready_pool())) {
RunnerCommandRefused { host_label: _, reason: _ } => false
RunnerCommandReady { command: cmd } => {
let enable = shell_command_render(command: cmd)
list_length(items: names) == srv4_runner_host_deploy.runner_count
&& string_contains(s: enable, pattern: "'actions-runner@srv4-01.service'")
&& string_contains(s: enable, pattern: "'actions-runner@srv4-05.service'")
&& all(names, n => string_contains(s: enable, pattern: n))
&& !string_contains(
s: enable,
pattern: concat("srv4-", runner_slot_index_suffix(index: srv4_runner_host_deploy.runner_count + 1)),
)
&& string_contains(
s: enable,
pattern: concat(
concat("'", sudo_binary_path as String),
concat("' '", concat(sudo_non_interactive_flag as String, "'")),
),
)
&& string_contains(
s: enable,
pattern: concat(concat("'", systemctl_program as String), "' 'enable' '--now'"),
)
}
}
list_length(items: names) == srv4_runner_host_deploy.runner_count
&& string_contains(s: enable, pattern: "'actions-runner@srv4-01.service'")
&& string_contains(s: enable, pattern: "'actions-runner@srv4-05.service'")
&& all(names, n => string_contains(s: enable, pattern: n))
&& !string_contains(
s: enable,
pattern: concat("srv4-", runner_slot_index_suffix(index: srv4_runner_host_deploy.runner_count + 1)),
)
&& string_contains(
s: enable,
pattern: concat(
concat("'", sudo_binary_path as String),
concat("' '", concat(sudo_non_interactive_flag as String, "'")),
),
)
&& string_contains(
s: enable,
pattern: concat(concat("'", systemctl_program as String), "' 'enable' '--now'"),
)
}

data unenrolled_host_fixture: RunnerHostDeploy = RunnerHostDeploy {
Expand Down
Loading