Skip to content

Emitted-Rust repair: delete the hardcoded Box in rust_host_string_op_fn_emit's string_head arm (string_tail is the control) #9034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
briansrls merged 3 commits into from
Aug 24, 2026
Merged

Emitted-Rust repair: delete the hardcoded Box in rust_host_string_op_fn_emit's string_head arm (string_tail is the control) #9034

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
79fdb7c
Fix emitted string_head CharResult payload
Aug 23, 2026
e854291
Merge remote-tracking branch 'origin/main' into tmp-9034
Aug 23, 2026
c3a98d5
Merge remote-tracking branch 'origin/main' into tmpb
Aug 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/v1/05_emit_rust.dag
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -392,7 +392,7 @@ fn rust_host_string_op_fn_emit(name: String) -> String? {
Present { value: concat(
"pub fn string_head(s: String) -> Rc<CharResult> {\n",
" match s.chars().next() {\n",
" Some(c) => Rc::new(CharResult::CharFound { value: Box::new(c as i64) }),\n",
" Some(c) => Rc::new(CharResult::CharFound { value: c as i64 }),\n",
" None => Rc::new(CharResult::CharAbsent),\n",
" }\n",
"}\n"
Expand Down
2 changes: 1 addition & 1 deletion src/v1/stage0/src/v1_compiler_emit_rust.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -662,7 +662,7 @@ pub fn rust_host_string_op_fn_emit(name: String) -> Option<String> {
))
} else {
if (name.clone() == "string_head".to_string()) {
Some(v1_rt::concat(v1_rt::concat(v1_rt::concat(v1_rt::concat(v1_rt::concat("pub fn string_head(s: String) -> Rc<CharResult> {\n".to_string(), " match s.chars().next() {\n".to_string()), " Some(c) => Rc::new(CharResult::CharFound { value: Box::new(c as i64) }),\n".to_string()), " None => Rc::new(CharResult::CharAbsent),\n".to_string()), " }\n".to_string()), "}\n".to_string()))
Some(v1_rt::concat(v1_rt::concat(v1_rt::concat(v1_rt::concat(v1_rt::concat("pub fn string_head(s: String) -> Rc<CharResult> {\n".to_string(), " match s.chars().next() {\n".to_string()), " Some(c) => Rc::new(CharResult::CharFound { value: c as i64 }),\n".to_string()), " None => Rc::new(CharResult::CharAbsent),\n".to_string()), " }\n".to_string()), "}\n".to_string()))
} else {
if (name.clone() == "string_tail".to_string()) {
Some(v1_rt::concat(v1_rt::concat(v1_rt::concat(v1_rt::concat(v1_rt::concat(v1_rt::concat("pub fn string_tail(s: String) -> Rc<ListTailResult<Char>> {\n".to_string(), " let mut __it = s.chars();\n".to_string()), " match __it.next() {\n".to_string()), " Some(_) => Rc::new(ListTailResult::TailFound { tail: Rc::new(__it.map(|c| c as i64).collect::<Vec<i64>>()) }),\n".to_string()), " None => Rc::new(ListTailResult::TailAbsent),\n".to_string()), " }\n".to_string()), "}\n".to_string()))
Expand Down
Loading