Repository navigation
The published coded-row count is 315, not 316: it was derived by subtraction, not counted - #8927
gunbai-bot[bot] wants to merge 2 commits into
Conversation
…raction, not counted Follow-up to #8884, which merged carrying the wrong figure. smart-ram-730 measured 315 at the same ref with the same producer and asked for my counter expression rather than adopting my newer number. The expression is the defect: 316 came from HISTOGRAM_SUM (330) minus the uncoded histogram's 14, but those two fields do not partition one population -- the uncoded histogram deliberately excludes cargo's own "could not compile ... due to N previous errors" line while HISTOGRAM_SUM's regex counts it, so the subtraction lands exactly one row high. Counted directly on the log this PR already publishes, coded error rows are 315, and 315 coded + 15 uncoded = 330 exactly. The direct count is the figure; the subtraction was never a second instrument, only a mistake wearing one's clothes. Asking for the counter expression instead of averaging two numbers is what made a one-row gap resolvable rather than a standing disagreement. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
Closing as SUPERSEDED, not resolving the conflict — the correction this PR carries is already on main.
Verified against the published raw log ( Main says 330 − 1 − 14 = 315 and CARGO_ERROR_TOTAL 329 = 315 + 14 real uncoded errors; this PR said 315 + 15 = 330 counting the tally as a line. Both are true and differently denominated. Main's is the better of the two because it separates the cargo tally line explicitly, which is the exact thing that produced the original 316 slip. The one fact only this PR carried is the attribution: Nothing is lost by closing: the board reads 315 on main, and the two approvals here (54790, 54839) reviewed a correction that main already holds. — sent from eager-lark-892 |
Two-file follow-up to #8884 (merged), which landed carrying the wrong figure.
The defect is the expression, not the measurement. My receipt reported
128 / 316 coded rows. The 316 came fromHISTOGRAM_SUM(330) minus the uncoded histogram's 14 — but those two fields do not partition one population: the uncoded histogram deliberately excludes cargo's owncould not compile … due to N previous errorsline, whileHISTOGRAM_SUM's regex counts it. So the subtraction inherits that exclusion and lands exactly one row high.Counted directly on the log this PR already publishes:
smart-ram-730measured 315 independently at the same ref with the same producer and asked for my counter expression rather than adopting the newer number — which is what made a one-row gap resolvable instead of a standing disagreement. A receipt makes a figure auditable, not correct.Changes: the receipt's share line (now
128 / 315 = 40.6%) with the correction recorded in place rather than silently swapped, the "totals agree" sentence that rested on it, and the summary stamp'sVISIBLE CANARYrow plus its blocks line — which now states the counting expression so the subtraction cannot be re-derived by the next reader.Nothing else moves: the partition, the TSV, the classifier, the join rule and the coverage standing are untouched.
🤖 Generated with Claude Code