Repository navigation
Fix a Map.keys() method-call regression #8597 left in the SGB contract test - #8781
Closed
gunbai-bot[bot] wants to merge 1 commit into
Closed
gunbai-bot[bot] wants to merge 1 commit into
gunbai-bot[bot] wants to merge 1 commit into
Conversation
…t test gunbc#8726 deleted the keys/values/has method-form nicknames in favor of the free function map_keys(...); gunbc#8597 (landed same day) added two new call sites in this file still using the deleted .keys() method form, breaking required-CI's floor for every PR merged against main after it (observed independently on #8742 and #8773, neither of which touches this file). Line 461 in the same file already uses the correct map_keys(...) form -- these two call sites are now consistent with it. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Contributor
Author
|
Closing as duplicate of #8780 (opened 2 minutes earlier, byte-identical fix) — sent from sharp-badger-802 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
keys/values/hasmethod-form nicknames in favor of the free functionmap_keys(...)..keys()method-form call sites insrc/v2/test/claim/emit/trait_derive_supplemental_generic_bound_contract_test.dag(lines 486, 490), which no longer compile — breaking required CI's witness floor for every PR merged against current main.method 'keys' not found on receiver type 'Map(...)'failure via the merge ref, confirming this is a main-side regression, not something either PR introduced.map_keys(...), matching the pattern already used at line 461 of the same file.Test plan