Repository navigation
Retire orphaned checkpoint blob from language scaffold roster - #8403
Merged
Merged
Conversation
Root B moved ct_groupcompletion_checkpoint_fires_under_faithful_corpus_test into v1.tests.claim.checkpoint_identity_keying_witness_test but left its language_source_scaffold_index row behind, so compiler_tests_rust_blobs_are_all_rostered counted 41 rostered blobs against 40 live ct_ declarations. Co-authored-by: Cursor <cursoragent@cursor.com>
gunbai-bot
Bot
changed the title
The fold matched std.upsert_decision.Absent on a NetplanConfigFile? input, so none/null fell through and host_network_diagnosis_witnesses errored at runtime with a non-exhaustive pattern match. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root B (#8357) migrated
ct_groupcompletion_checkpoint_fires_under_faithful_corpus_testintov1.tests.claim.checkpoint_identity_keying_witness_testbut left itslanguage_source_scaffold_indexrow behind, socompiler_tests_rust_blobs_are_all_rosteredcounted 41 rosteredct_blobs against 40 live declarations.The two
runner_slot_provision_witness_testreconcile failures were already repaired on main by #8401. This PR closes the remaining scaffold witness and includes a one-line fix forhost_network_diagnosismatchingstd.upsert_decision.Absenton aNetplanConfigFile?(runtime non-exhaustive match onnone).Merged latest
main(inference spring clean #8389) to pick up reconcile cost reductions before re-running witnesses.Test plan
ct_fns == 40 rostered blobs.witnessesworkflow on this PR.