Repository navigation
#8352 FIX: Retire CiRegenStage from owned-CI executor - #8354
Closed
gunbai-bot[bot] wants to merge 1 commit into
Closed
gunbai-bot[bot] wants to merge 1 commit into
gunbai-bot[bot] wants to merge 1 commit into
Conversation
The regen_stage0 binary was deleted by the v1 cut PR, leaving the owned-CI executor with a stale dispatch to a deleted authority. CiRegenStage is now retired completely per DESIGN §3 step 6 (replacement cut). DISPOSITION: retire CiRegenStage, not replace. - regen_stage0 binary is deleted with no successor - nothing else constructs CiRegenStage - the binary's source (src/v1/stage0/src/bin/regen_stage0.rs) is deleted - the v1 cut program intentionally reduced regen references from 28 to 6 on main, establishing the clear intent of the binary deletion The 7 regenerated files the v1 cut author cited (compiler_tests, lib, v1_rt, v1_test_non_ascii_perf_fixture, wt_a, wt_b, wt_common) do not require owned-CI dispatch — they are build-time outputs, not part of the owned executor's pipeline. Changes: - Remove CiRegenStage from CiExecutionStage type - Remove CiRegenStage from ci_execution_default_stages (was [Build, Regen, Floor], now [Build, Floor]) - Remove CiRegenStage arm from ci_execution_stage_wire match - Remove stage_regen function from ci_control_plane.rs - Remove "regen" dispatch arm from ci_control_plane.rs - Update owned_ci_witness_test to assert the new 2-stage order (witness_execution_plan_stages_build_regen_floor → witness_execution_plan_stages_build_floor) Fixes #8352 REQUEST_CHANGES Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session/crisp-boar-827
Contributor
Author
|
Closing in favor of a correctly-targeted fix. This PR targets main, but the REQUEST_CHANGES feedback is on PR #8352 which is based on integration/v1-cut. The fix needs to land on that branch to resolve the reviewer's findings. Pushing the same change to integration/v1-cut instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses REQUEST_CHANGES feedback on PR #8352 (review 52732). The owned-CI executor was still dispatching a CiRegenStage that spawned the deleted
regen_stage0binary.Disposition
Retire CiRegenStage, not replace. The evidence:
regen_stage0binary is deleted with no successorsrc/v1/stage0/src/bin/regen_stage0.rsis deletedCiRegenStageThe 7 regenerated files the v1 cut author cited (compiler_tests, lib, v1_rt, v1_test_non_ascii_perf_fixture, wt_a, wt_b, wt_common) are build-time outputs, not part of the owned executor's pipeline, so they do not require dispatch.
Changes
CiRegenStagefromCiExecutionStagetypeCiRegenStagefromci_execution_default_stages(was[Build, Regen, Floor], now[Build, Floor])CiRegenStagearm fromci_execution_stage_wirematchstage_regen()function fromci_control_plane.rs"regen"dispatch arm fromci_control_plane.rsowned_ci_witness_testto assert new 2-stage orderwitness_execution_plan_stages_build_regen_floor→witness_execution_plan_stages_build_floor[CiBuildStage, CiFloorStage]Per DESIGN §3 step 6: the disposition receipt names what is retired (the binary and its dispatch infrastructure) and why the subject is gone (it was deleted, nothing else constructs it).
🤖 Generated with Claude Code
https://claude.ai/code/session/crisp-boar-827