Repository navigation
Admit source annotations on the via-index compile path - #8216
Merged
Merged
Conversation
gunbai-bot
Bot
force-pushed
the
session/royal-heron-787
branch
from
August 13, 2026 13:28
85c6ba5 to
cfe7469
Compare
The floor's cached parse used annotation-erasing tokenize, so a touched in-closure file could miss SourceAnnotationRefused — the class #8204 claims to close. Carry tokenize_artifact captures through that parse and admit them, and run the out-of-closure census independently of resolve so an earlier refusal cannot hide the population. Co-authored-by: Cursor <cursoragent@cursor.com>
Via-index admission made the floor see BodyGrain and Unattached forms the previous path erased. The class stays a hard red; the corpus no longer inhabits it. Compile-clean now names the refusing file so a recurrence is locatable. Co-authored-by: Cursor <cursoragent@cursor.com>
Rebase onto main brought Spatial-5/6 sources under via-index admission; compile-clean now sees the BodyGrain and Unattached forms those files still carried. The class stays a hard red. Co-authored-by: Cursor <cursoragent@cursor.com>
gunbai-bot
Bot
force-pushed
the
session/royal-heron-787
branch
from
August 13, 2026 16:35
993ecad to
40f89c8
Compare
handle_serve resolves Memoize, consumes compile_clean_diags, and shares process_shared_index, so gating warm re-admission on Ephemeral made BodyGrain depend on cache state. Co-authored-by: Cursor <cursoragent@cursor.com>
gunbai-bot Bot
pushed a commit
that referenced
this pull request
Aug 13, 2026
This PR's CI failure was never its own. Its base predated #8201/#8215/#8216, so its floor run inherited the corpus-wide in-body and unattached source-annotation refusals; its single changed file carries neither form. #8235 has since moved all 87 body-grain annotations to module-item grain and main carries none. Merge only — no content of this PR is touched.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resolved_graph_from_sources_with_index) used annotation-erasingtokenize, so a touched in-closure file could compile while missingSourceAnnotationRefused— the class Restore whole-tree census fill on scoped compile-clean gate #8204 claims to close. The ordinary frontend already admits viatokenize_artifact+admit_source_annotations; via-index now does the same for the files it actually compiles.parse_cachestores those admission diagnostics on the installing parse.handle_serveresolvesMemoize, consumescompile_clean_diags, and sharesprocess_shared_index, so re-admission is no longer gated onEphemeral.Test plan
cargo test -p v1-compiler --lib compile_clean_via_index_verdict_equivalence— including: