Skip to content

Admit source annotations on the via-index compile path - #8216

Merged
briansrls merged 4 commits into
mainfrom
session/royal-heron-787
Aug 13, 2026
Merged

briansrls merged 4 commits into
mainfrom
session/royal-heron-787

Conversation

@gunbai-bot

@gunbai-bot gunbai-bot Bot commented Aug 13, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Test plan

  • cargo test -p v1-compiler --lib compile_clean_via_index_verdict_equivalence — including:
    • in-closure BodyGrain RED on via-index (census_only empty, so Restore whole-tree census fill on scoped compile-clean gate #8204 cannot explain it)
    • in-closure UnattachedAtScopeEnd RED on via-index
    • leading item prose stays green
    • in-closure BodyGrain still visible when resolve also refuses
    • out-of-closure trailing still visible when resolve also refuses
    • warm parse_cache still reds on in-closure BodyGrain (Ephemeral then Ephemeral)
    • Ephemeral then Memoize (handle_serve shape: parse_cache hit, memo miss) still reds BodyGrain
    • annotation-erasing parse_cache install then Memoize still reds BodyGrain
    • existing Restore whole-tree census fill on scoped compile-clean gate #8204 out-of-closure trailing RED and green/unresolved/typecheck equivalence

@gunbai-bot gunbai-bot Bot changed the title Migrate the census-fill annotation mechanism from cli_run.rs into .dag and delete the Rust in the same diff (corrects #8204) Admit source annotations on the via-index compile path Aug 13, 2026
@gunbai-bot
gunbai-bot Bot marked this pull request as ready for review August 13, 2026 06:24
@gunbai-bot
gunbai-bot Bot force-pushed the session/royal-heron-787 branch from 85c6ba5 to cfe7469 Compare August 13, 2026 13:28
gunbc-ci-auto-heal and others added 3 commits August 13, 2026 16:33
The floor's cached parse used annotation-erasing tokenize, so a touched in-closure file could miss SourceAnnotationRefused — the class #8204 claims to close. Carry tokenize_artifact captures through that parse and admit them, and run the out-of-closure census independently of resolve so an earlier refusal cannot hide the population.

Co-authored-by: Cursor <cursoragent@cursor.com>
Via-index admission made the floor see BodyGrain and Unattached forms the previous path erased. The class stays a hard red; the corpus no longer inhabits it. Compile-clean now names the refusing file so a recurrence is locatable.

Co-authored-by: Cursor <cursoragent@cursor.com>
Rebase onto main brought Spatial-5/6 sources under via-index admission; compile-clean now sees the BodyGrain and Unattached forms those files still carried. The class stays a hard red.

Co-authored-by: Cursor <cursoragent@cursor.com>
@gunbai-bot
gunbai-bot Bot force-pushed the session/royal-heron-787 branch from 993ecad to 40f89c8 Compare August 13, 2026 16:35
handle_serve resolves Memoize, consumes compile_clean_diags, and shares process_shared_index, so gating warm re-admission on Ephemeral made BodyGrain depend on cache state.

Co-authored-by: Cursor <cursoragent@cursor.com>
@briansrls
briansrls merged commit 9194777 into main Aug 13, 2026
5 checks passed
@briansrls
briansrls deleted the session/royal-heron-787 branch August 13, 2026 18:17
gunbai-bot Bot pushed a commit that referenced this pull request Aug 13, 2026
This PR's CI failure was never its own. Its base predated #8201/#8215/#8216, so
its floor run inherited the corpus-wide in-body and unattached source-annotation
refusals; its single changed file carries neither form. #8235 has since moved all
87 body-grain annotations to module-item grain and main carries none.

Merge only — no content of this PR is touched.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant