Repository navigation
Restore emit_field_eval_alt_descent_producer_tree for field-access witness - #8097
Merged
Merged
Conversation
…tness. PR #7287 deleted the alt-descent producer tree while leaving the import in emit_on_demand_field_access_family_witness_test and a String note describing the missing tree. Restore the composed facts and producer function, and drop the dead commentary row. Co-authored-by: Cursor <cursoragent@cursor.com>
CI refused orphan plain fns in *_test.dag; add a test fn that exercises emit_field_eval_alt_descent_producer_tree so the restored helpers are reachable from enrolled witnesses. Co-authored-by: Cursor <cursoragent@cursor.com>
The separate alt_descent test fn was UnclassifiedPathDeferral under the execution/ OfflineLocalRecipe path policy. Exercise the alt producer tree from emit_host_field_access_equals_eval_holds, which already has admission. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
emit_field_eval_alt_descent_composed_factsandemit_field_eval_alt_descent_producer_treeinemit_host_field_access_equals_eval_test.dag, fixing the broken import inemit_on_demand_field_access_family_witness_test.dag.emit_field_eval_alt_descent_producer_noteString row (DESIGN 4c commentary-as-data) that replaced the deleted implementation in test umbrella dissolution: corpus sweep B (src/v2 + orphan wire) #7287.The alt tree uses the same
dag_field_access_arrow_with_body_fixtureroot with a different descent ranking symbol (^emit_field_eval_alt_descent), giving a distinctinferred_tree_digest/ native cache key while emitting the same valid Rust (r.0→ octet 9).Test plan
emit_on_demand_field_access_family_witness_testwitnesses execute green (closure key differ, native one-build)emit_host_field_access_equals_eval_testwitnesses remain greenMade with Cursor