Repository navigation
Fix main-red witness imports and located floor terminal refusals - #8058
Merged
Merged
Conversation
…l refusals. Twenty-five discovery witnesses failed with no such function because extdeps grounding tests relied on pool-membership resolution instead of explicit imports; add the missing import rows. The coordinator previously replayed only walk terminal exit code 1 while the worker had already emitted the real batch refusal on stderr — walk_terminal_detail now carries mode, ci_failure_class_arm, and failure_details into the terminal receipt. Co-authored-by: Cursor <cursoragent@cursor.com>
This was referenced Aug 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
8ef88e95ee): batch 3 reported 25 discovery witness reds (no such function: …) inextdeps_anemia_grounding_witness_test.dag,extdeps_round2_grounding_witness_test.dag, andhardware_selection_witness_test.dag. Those files only importedampereand relied on pool-membership resolution for every other symbol; once the closure no longer dragged those modules in, resolution failed. This PR adds explicit import rows for each authority (sql/http/cloud/gpu/cpu/memory/product/hardware_selection).[falsifier-failure-class]with the full batch detail, butfloor_terminal_fast_exitwrote onlywalk terminal exit code 1into the terminal receipt, which is what the coordinator surfaced.walk_terminal_detailnow projectsmode,ci_failure_class_arm, and joinedfailure_detailsinto the receipt so a terminal exit 1 names the refusal.Not in scope (escalation): run
31269330339(e52f99fac1e, #8046) completed the discovery corpus (drain receipt + measurement at ~45m) but the CI step failed after ~71m with no✗ FAIL/walk terminalline in the failed log — consistent with step timeout or outer cgroup kill after the receipt, not witness reds. That belongs to the run-stability / step-budget lane.Test plan
cargo test -p v1-compiler --bin claim_executor walk_terminalclaim_batch --function w_sql_dialect_postgres_labelonextdeps_round2_grounding_witness_test.dagclaim_batch --function w_cpu_tdp_watts_power_dimensiononextdeps_anemia_grounding_witness_test.dagclaim_batch --function downclock_is_rank_dependentonhardware_selection_witness_test.dagMade with Cursor