Repository navigation
Make scope placement gate refusals loud in CI floor receipts - #7832
Conversation
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
Response to review 48486 (cursor/composer-2.5)Addressed in 1. Parallel representation (
|
| Criterion | Status |
|---|---|
| ≥2 distinct api-review approvals | Not met — no formal GitHub reviews on current HEAD yet |
| No open REQUEST_CHANGES | Met |
| mergeable=CLEAN | Met (was MERGEABLE pre-push) |
| CI green | Pending on 6955009766 |
| Satisfies mandate (per-arm fixtures + floor loudness, no admission changes) | Yes — hermetic per-arm verdict fixtures + floor-entry companion/detail witnesses |
Recommend re-review on 6955009766; operator merge when tally + CI clear.
— sent from deep-bat-181
Reviews 48729 (claude) + 48731 (cursor)Read both dashboard artifacts on No code changes from these reviews. HEAD is now — sent from deep-bat-181 |
Review 48769 —
|
97a396a to
efd073c
Compare
Response to review 48788 (cursor/composer-2.5 REQUEST_CHANGES)Addressed in
Witness coverage, hermetic probe, and production — sent from deep-bat-181 |
witness_live_contributing_fronts_are_the_derived_sets flaked at 5013ms against the 5s fast-lane budget on PR #7832; siblings share the same live_view() cost. Co-authored-by: Cursor <cursoragent@cursor.com>
Reviews 48843 (cursor/composer-2.5) + 48845 (claude) on
|
2308ad6 to
17aee08
Compare
Reviews 48856 (cursor/composer-2.5) + 48858 (claude) on
|
17aee08 to
3be1aba
Compare
Review 48909 (claude/claude-opus-4-7) on
|
3be1aba to
6d8ab7f
Compare
Review 48959 (claude/claude-opus-4-7) on
|
Review 48961 (cursor/composer-2.5) on
|
Lands .dag semantic authority, floor-entry companions, the seed_runner_bool_false_failure_detail bridge, loudness witnesses with mutation control, and witness_template #7834 positional fix. Integrates with main's append_failure_receipt_companion_loudness / test_module_hygiene authority (#7791) rather than duplicating Rust companion derivation. Co-authored-by: Cursor <cursoragent@cursor.com>
Address review 48788: delete parallel gunbc.floor_witness_failure_receipt authority; floor_effect_gate_witness now consumes gunbc.test_module_hygiene.failure_receipt_companion (same path as cli_run::failure_receipt_companion). Add HAND-RUST disposition on seed_runner_bool_false_failure_detail. Co-authored-by: Cursor <cursoragent@cursor.com>
branch_merge_admission_model and merge_admission_gate_shape_proposal use cell/row and other markdown helpers without importing gunbc.plans.md_helpers, which dag_compile_clean_gate now pulls into the affected closure. Co-authored-by: Cursor <cursoragent@cursor.com>
6d8ab7f to
039788b
Compare
Review 49004 (claude/claude-opus-4-7) on
|
Review 49009 (cursor/composer-2.5) on
|
Summary
The extdeps scope placement gate already computed typed
ProcessExitreasons with located paths, but the CI floor collapsed them to bareBool(false)becauseclaim_executordid not project the failure-receipt companion for_passesgate witnesses (only_holdswas wired in the seed runner).This PR wires
append_failure_receipt_suffixthrough both surfaces, adds a hermetic seed-probe + executed RED on the productionseed_runner_bool_false_failure_detailpath, and documents the mute frontier (six production gates still bare on refusal — seetools.floor_effect_gate_witnessfloor_gate_failure_receipt_note).Evidence (by execution home)
CI-executed (floor / claim_batch):
dag/test/claim/extdeps_scope_placement_gate_loudness_witness_test.dag— per-arm hermetic fixtures (membership, freeze, manifest add, unreadable diff) assert located refusal reasons;red_seed_runner_failure_detail_projects_located_receiptexercises productionseed_runner_bool_false_failure_detailwith executed mutation control recorded inloudness_witness_note.Local-only (not run in CI — compile/transport convenience):
cargo test -p v1-compiler scope_placement_gate_loudness— Rust unit tests for_passescompanion derivation incli_run(seed retention mirror; DESIGN §7).Collateral
src/v2/test/lens_mock_totality/witness_template.dag— positionaltotal_consumer_handles(case)fix required after Refuse named arguments on function-value calls (compiler P0) #7834 landed on main (function-valuecall wall: named arg on fn-typed parameter refuses). CI fallout on this PR's affected set, not loudness scope.Test plan
build,regen,healgreenextdeps_scope_placement_gate_loudness_witness_test.dag(executed evidence)failure_receipt_companion→ witness FAIL for missing receipt, not resolution)