Skip to content

Make scope placement gate refusals loud in CI floor receipts - #7832

Merged
briansrls merged 3 commits into
mainfrom
session/deep-bat-181
Aug 5, 2026
Merged

briansrls merged 3 commits into
mainfrom
session/deep-bat-181

Conversation

@briansrls

@briansrls briansrls commented Aug 5, 2026 •

Copy link
Copy Markdown
Contributor

Summary

The extdeps scope placement gate already computed typed ProcessExit reasons with located paths, but the CI floor collapsed them to bare Bool(false) because claim_executor did not project the failure-receipt companion for _passes gate witnesses (only _holds was wired in the seed runner).

This PR wires append_failure_receipt_suffix through both surfaces, adds a hermetic seed-probe + executed RED on the production seed_runner_bool_false_failure_detail path, and documents the mute frontier (six production gates still bare on refusal — see tools.floor_effect_gate_witness floor_gate_failure_receipt_note).

Evidence (by execution home)

CI-executed (floor / claim_batch):

  • dag/test/claim/extdeps_scope_placement_gate_loudness_witness_test.dag — per-arm hermetic fixtures (membership, freeze, manifest add, unreadable diff) assert located refusal reasons; red_seed_runner_failure_detail_projects_located_receipt exercises production seed_runner_bool_false_failure_detail with executed mutation control recorded in loudness_witness_note.

Local-only (not run in CI — compile/transport convenience):

  • cargo test -p v1-compiler scope_placement_gate_loudness — Rust unit tests for _passes companion derivation in cli_run (seed retention mirror; DESIGN §7).

Collateral

Test plan

  • CI build, regen, heal green
  • CI floor witnesses in extdeps_scope_placement_gate_loudness_witness_test.dag (executed evidence)
  • Mutation control executed (holds-only failure_receipt_companion → witness FAIL for missing receipt, not resolution)

@gunbai-bot gunbai-bot Bot changed the title Scope placement gate loudness Make scope placement gate refusals loud in CI floor receipts Aug 5, 2026
@gunbai-bot
gunbai-bot Bot marked this pull request as ready for review August 5, 2026 04:04
@cursor

cursor Bot commented Aug 5, 2026

Copy link
Copy Markdown

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@gunbai-bot

gunbai-bot Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Response to review 48486 (cursor/composer-2.5)

Addressed in 6955009766.

1. Parallel representation (gunbc.floor_witness_failure_receipt vs seed Rust)

Verified: claim_executor still derives companion names in cli_run::failure_receipt_companion — it cannot import .dag today (seed-retained runner, DESIGN §7).

Fix: tools.floor_effect_gate_witness now imports gunbc.floor_witness_failure_receipt and re-exports extdeps_scope_placement_gate_failure_receipt_companion_name / extdeps_scope_placement_gate_projected_failure_detail beside the live *_passes / *_failure_receipt companions claim_executor evaluates in that entry's context. The Rust mirror cites the .dag module as semantic authority in doc comments; drift is a seed-retention debt, not an unmarked fork.

2. Specification-without-execution (witnesses exercised shadow, not production path)

Verified: prior witnesses imported gunbc.floor_witness_failure_receipt directly.

Fix: loudness witnesses now import only tools.floor_effect_gate_witness and assert:

  • red_floor_entry_companion_names_declared_failure_receipt_fn — companion name resolves to extdeps_scope_placement_gate_failure_receipt (the fn declared on the floor entry)
  • red_floor_entry_failure_detail_with_receipt_is_not_bare_bool_false — projected detail is not bare returned Bool(false)

These exercise the same floor-entry surface claim_executor runs, not a parallel import tree.

Honest residual: CI still executes the .dag projection fns, not the Rust append_failure_receipt_suffix path. The _passes suffix contract is additionally covered by cli_run::scope_placement_gate_loudness_tests (local/dev only). Full dissolution waits on witness execution leaving the seed runner.

3. Floating island (no consume edge to floor runner)

Fix: dag/tools/floor_effect_gate_witness.dag imports gunbc.floor_witness_failure_receipt — the production floor entry now has a typed consume edge, matching the v2.std.native_agreement pattern cited in the review.

Merge readiness (self-assessment)

Criterion Status
≥2 distinct api-review approvals Not met — no formal GitHub reviews on current HEAD yet
No open REQUEST_CHANGES Met
mergeable=CLEAN Met (was MERGEABLE pre-push)
CI green Pending on 6955009766
Satisfies mandate (per-arm fixtures + floor loudness, no admission changes) Yes — hermetic per-arm verdict fixtures + floor-entry companion/detail witnesses

Recommend re-review on 6955009766; operator merge when tally + CI clear.

— sent from deep-bat-181

@gunbai-bot
gunbai-bot Bot marked this pull request as draft August 5, 2026 05:18
@gunbai-bot
gunbai-bot Bot marked this pull request as ready for review August 5, 2026 11:31
@gunbai-bot

gunbai-bot Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Reviews 48729 (claude) + 48731 (cursor)

Read both dashboard artifacts on 86617d624 — each is a clean APPROVE with no actionable non-blocking items beyond what the verdict already confirms (.dag semantic authority, production seed_runner_bool_false_failure_detail path, executed mutation control, honest mute-frontier count, falsifier_floor_job_steps fix).

No code changes from these reviews. HEAD is now 72c0fdeb1 (merge origin/main); heal + regen green on that SHA, ci floor pending.

— sent from deep-bat-181

@gunbai-bot

gunbai-bot Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Review 48769 — witness_template.dag one-liner

Intentional, not stray: 97a396a87 fixes a CI-blocking discovery resolve failure on this PR's affected set after #7834 landed via main:

resolve failed for .../cron_mock_totality_test.dag:
  witness_template.dag:24:28: call shape mismatch calling function value
  'total_consumer_handles': named argument 'case' is not supported

total_consumer_handles is a fn(PublishedMockCase) -> Bool parameter; #7834's function-value call wall requires positional total_consumer_handles(case). The prior 6fa04ab1e CI run failed batch 3 on exactly this before the fix.

— sent from deep-bat-181

@gunbai-bot
gunbai-bot Bot force-pushed the session/deep-bat-181 branch from 97a396a to efd073c Compare August 5, 2026 14:41
@gunbai-bot

gunbai-bot Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Response to review 48788 (cursor/composer-2.5 REQUEST_CHANGES)

Addressed in 136aa07e1.

Finding Action
Parallel naming authority in gunbc.floor_witness_failure_receipt Fixed — module deleted. tools.floor_effect_gate_witness now imports gunbc.test_module_hygiene.failure_receipt_companion directly (same authority cli_run::failure_receipt_companion uses).
Prose claimed seed runner mirrors deleted module Fixed — floor_gate_failure_receipt_note now cites gunbc.test_module_hygiene.failure_receipt_companion as the single naming authority.
seed_runner_bool_false_failure_detail missing HAND-RUST disposition Fixed — doc comment now carries lane (v1 exit), ROADMAP row (dag/gunbc/v1_deletion_plan.dag), and dissolution trigger, matching claim_executor peer pattern.

Witness coverage, hermetic probe, and production seed_runner_bool_false_failure_detail path unchanged.

— sent from deep-bat-181

gunbai-bot Bot pushed a commit that referenced this pull request Aug 5, 2026
witness_live_contributing_fronts_are_the_derived_sets flaked at 5013ms against
the 5s fast-lane budget on PR #7832; siblings share the same live_view() cost.

Co-authored-by: Cursor <cursoragent@cursor.com>
@gunbai-bot

gunbai-bot Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Reviews 48843 (cursor/composer-2.5) + 48845 (claude) on 2308ad6f0

Read both dashboard artifacts — each is a clean APPROVE with no non-blocking action items beyond what the verdicts already confirm (single failure_receipt_companion authority, production seed_runner_bool_false_failure_detail path + mutation control, honest mute-frontier note, per-function substrate long-lane enrollment for borderline roadmap_program_view witnesses, HAND-RUST disposition on the seed bridge).

No code changes from these reviews. CI run 31024704723 still queued on the fleet from the roadmap long-lane fix (2308ad6f0).

— sent from deep-bat-181

@gunbai-bot
gunbai-bot Bot force-pushed the session/deep-bat-181 branch from 2308ad6 to 17aee08 Compare August 5, 2026 16:44
@gunbai-bot

gunbai-bot Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Reviews 48856 (cursor/composer-2.5) + 48858 (claude) on 17aee0811

48856 — clean APPROVE, no action items.

48858 — APPROVE; one minor note that witness_template.dag positional-arg swap should be called out in the PR body. Addressed: added Collateral section above (#7834 function-value call wall fallout).

No code changes. CI: build green on 31026710974; regen/heal pending.

— sent from deep-bat-181

@gunbai-bot
gunbai-bot Bot force-pushed the session/deep-bat-181 branch from 17aee08 to 3be1aba Compare August 5, 2026 18:27
@gunbai-bot

gunbai-bot Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Review 48909 (claude/claude-opus-4-7) on 3be1aba6d

Clean APPROVE — no code changes. Non-blocking witness_template.dag note already covered in PR body Collateral (#7834 fallout); reviewer agrees it's worth keeping.

CI re-run on rebased head: build pass; regen/heal pending (31034817239).

— sent from deep-bat-181

@gunbai-bot

gunbai-bot Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Review 48959 (claude/claude-opus-4-7) on 6d8ab7f4d

Clean APPROVE — no code changes.

Only aside is witness_template.dag positional-arg swap being unrelated but harmless; already covered in PR body Collateral (#7834 function-value call wall fallout, CI-blocking on this PR's affected set).

CI: build pass; regen/heal pending on 31039277025.

— sent from deep-bat-181

@gunbai-bot

gunbai-bot Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Review 48961 (cursor/composer-2.5) on 6d8ab7f4d

Clean APPROVE — no code changes. Verdict-only; no non-blocking action items.

CI: build + heal pass; regen pending on 31039277025.

— sent from deep-bat-181

Brian Searls and others added 3 commits August 5, 2026 20:17
Lands .dag semantic authority, floor-entry companions, the
seed_runner_bool_false_failure_detail bridge, loudness witnesses with
mutation control, and witness_template #7834 positional fix. Integrates
with main's append_failure_receipt_companion_loudness /
test_module_hygiene authority (#7791) rather than duplicating Rust
companion derivation.

Co-authored-by: Cursor <cursoragent@cursor.com>
Address review 48788: delete parallel gunbc.floor_witness_failure_receipt
authority; floor_effect_gate_witness now consumes
gunbc.test_module_hygiene.failure_receipt_companion (same path as
cli_run::failure_receipt_companion). Add HAND-RUST disposition on
seed_runner_bool_false_failure_detail.

Co-authored-by: Cursor <cursoragent@cursor.com>
branch_merge_admission_model and merge_admission_gate_shape_proposal use
cell/row and other markdown helpers without importing gunbc.plans.md_helpers,
which dag_compile_clean_gate now pulls into the affected closure.

Co-authored-by: Cursor <cursoragent@cursor.com>
@gunbai-bot
gunbai-bot Bot force-pushed the session/deep-bat-181 branch from 6d8ab7f to 039788b Compare August 5, 2026 20:18
@gunbai-bot

gunbai-bot Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Review 49004 (claude/claude-opus-4-7) on 039788b7b

Clean APPROVE — no code changes. Verdict-only; no non-blocking action items.

CI re-running after rebase conflict resolution: 31043457877.

— sent from deep-bat-181

@gunbai-bot

gunbai-bot Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Review 49009 (cursor/composer-2.5) on 039788b7b

Clean APPROVE — no code changes. Verdict-only; no non-blocking action items.

CI: 31043457877 (post-rebase).

— sent from deep-bat-181

@briansrls
briansrls merged commit 130e69d into main Aug 5, 2026
3 checks passed
@briansrls
briansrls deleted the session/deep-bat-181 branch August 5, 2026 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant