Repository navigation
Fix frontier probe resolve_module_not_found for large import closures - #7762
Conversation
|
Addressed review 47905 (REQUEST_CHANGES on The Fix: Added — sent from snappy-dove-447 |
Replace remaining surveyed/open wording with execution_measurement axes, add dated census at 9f978aa, and state that 27/27 rerun waits for the probe fix so manifests do not enshrine manifest-elision artifacts. Co-authored-by: Cursor <cursoragent@cursor.com>
Remove leftover conflict markers from the #7762 merge; keep dag_grammar_root import alongside path-only closure ingest. Route admission rejections through frontier_probe_receipt_from_assemble_rejection so rejection_chain and overlap roster bind on the corrected probe path. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
CI fix + review 47932 response (
|
review 47946 — fixed in
|
Bind commit↔tree via git.Inspect.ShowTree in well-formed checks, embed build commit/tree in the survey binary and refuse stale executables, and require every TSV shard to carry the complete subject with aggregation refusing mismatch. Block 27/27 on #7762 final + #7767; land release one-shot recipe in ci_layer_roots exclusion note. Co-authored-by: Cursor <cursoragent@cursor.com>
review 47964 — survey manifest detail round-tripFixed in fab6c83.
msg_3902e126 — parse error (expected FatArrow, found LBracket)Same commit. Root cause: Also corrected Note for PR body: v1 seed still panics in — sent from snappy-dove-447 |
Replace remaining surveyed/open wording with execution_measurement axes, add dated census at 9f978aa, and state that 27/27 rerun waits for the probe fix so manifests do not enshrine manifest-elision artifacts. Co-authored-by: Cursor <cursoragent@cursor.com>
Bind commit↔tree via git.Inspect.ShowTree in well-formed checks, embed build commit/tree in the survey binary and refuse stale executables, and require every TSV shard to carry the complete subject with aggregation refusing mismatch. Block 27/27 on #7762 final + #7767; land release one-shot recipe in ci_layer_roots exclusion note. Co-authored-by: Cursor <cursoragent@cursor.com>
…e lands. State explicitly that diagnostic_module_root_missing_qn_optional is a deliberate Absent stub waiting on parse-stage ModuleRootMissingEvidence, not silent debt. Co-authored-by: Cursor <cursoragent@cursor.com>
…ures. Large import closures exceeded MANIFEST_INLINE_LIST_MAX and produced Empty ingest, so assemble could not find the subject module. Frontier probe now builds ingest from path-only closure rows via filesystem_read, derives Admission from the parsed entry module (single authority with compile door), and records the exact missing QualifiedName on module_root_find diagnostics. Co-authored-by: Cursor <cursoragent@cursor.com>
Rewrite the missing-module identity witness to use nested match on diagnostic reason instead of a multiline == chain that the v1 module binding parser rejected (expected FatArrow, found EqEq). Co-authored-by: Cursor <cursoragent@cursor.com>
The module-binding parser accepts reason == ^atom on one line (as in name_resolve_cross_tree_resolution_test) but rejects match arms on ^resolve_module_not_found (expected FatArrow, found Caret). Co-authored-by: Cursor <cursoragent@cursor.com>
frontier_probe_receipt_for_entry surfaces admission derivation Rejections as typed FrontierProbeReceipt rows instead of substituting host_compiler_closure_admission on the live survey path (review 47905). Co-authored-by: Cursor <cursoragent@cursor.com>
…uthority imports. Populate required `detail` on every FrontierProbeReceipt constructor, restore TargetModel and DecodeFidelity imports dropped from source_authority, route frontier probe ingest through SourceRef read-through with typed read/hash refusal details, and fix port_locus call shapes that blocked regen and generated-artifact heal. Co-authored-by: Cursor <cursoragent@cursor.com>
CI builds with RUSTFLAGS=-D warnings; drop obsolete path-list helpers from the SourceRef overlay migration and remove unnecessary mut on the manifest append string. Co-authored-by: Cursor <cursoragent@cursor.com>
…on mismatch. Route SourceRootCoverageComplete ingest read failures through frontier_probe_receipt_from_ingest_read_rejected (not manifest-elided), extend FrontierProbeSourceReadRefused with observed_content_hash, and emit expected/observed digests in source_ref_content_hash_mismatch_diagnostic per ingest-manifest-source-ref-carrier design §5. Co-authored-by: Cursor <cursoragent@cursor.com>
Replace illegal list-pattern match on d.tail with fold_list (v1 bootstrap parser rejects []/[x] match arms). Fix source_authority diagnostic tails to List<Diagnostic>. Serialize computed FrontierProbeDetail in survey manifest. Co-authored-by: Cursor <cursoragent@cursor.com>
Regen verify failed because std.realization_schedule gained WitnessCostBasis, ScheduledWitnessEnvelope, and SpanEnrolled without updating the committed std_realization_schedule.rs seed. Co-authored-by: Cursor <cursoragent@cursor.com>
The Lane 3 frontier-probe enrollment patch added five SpanEnrolled rows; census witnesses still expected the pre-patch 51/40 split and failed CI. Co-authored-by: Cursor <cursoragent@cursor.com>
run_claim_timed records performance receipts from wall nanos while the eval budget gate uses thread CPU nanos; MeasuredAtExactSubject now carries clock plus duration_ms (msg_e24f4cab). Frontier probe enrollments label claim_batch receipt figures as WitnessCostWallEval. Co-authored-by: Cursor <cursoragent@cursor.com>
9f02e56 to
889ef41
Compare
Merge brought falsifier_workflow changes from main; sync committed workflow bytes to the generated projection authority. Co-authored-by: Cursor <cursoragent@cursor.com>
Ground WitnessCostBasis.duration and ScheduledWitnessEnvelope.wall_budget on std.measure Millisecond (RunnableBatchClamp precedent); update SpanEnrolled rows, merge-admission hashes, and emitted std_realization_schedule.rs. Refresh frontier_probe_survey scaffold receipt to main@546 → 821 LOC (+275). Co-authored-by: Cursor <cursoragent@cursor.com>
|
Addressed review 48582 on Millisecond carriers (BLOCKING items 1–2) — Hand-Rust receipt (BLOCKING item 3) — Local: — sent from snappy-dove-447 |
Regen_verify failed because the hand-edited emit seed diverged from v2 self-compile (generic bounds on cost_account_measured and schedule helpers). Run regen_stage0 after Millisecond carrier change. Co-authored-by: Cursor <cursoragent@cursor.com>
…ative run on hold) (#7763) * WIP: Lane 1: exact-current-head 27/27 frontier survey + status vocabulary cor * WIP: Lane 1: exact-current-head 27/27 frontier survey + status vocabulary cor * Lane 1: pin source_head and binary identity in survey manifest emission. frontier_probe_survey records git HEAD, binary sha256, and source_root in host_frontier_probe_survey_manifest; fix per-module script to use release binary. Co-authored-by: Cursor <cursoragent@cursor.com> * Document frontier survey hold on #7762 and silent-narrow refusal wall. Replace remaining surveyed/open wording with execution_measurement axes, add dated census at 9f978aa, and state that 27/27 rerun waits for the probe fix so manifests do not enshrine manifest-elision artifacts. Co-authored-by: Cursor <cursoragent@cursor.com> * WIP: Lane 1: exact-current-head 27/27 frontier survey + status vocabulary cor * Close three FrontierSurveySubject provenance holes (#7763). Bind commit↔tree via git.Inspect.ShowTree in well-formed checks, embed build commit/tree in the survey binary and refuse stale executables, and require every TSV shard to carry the complete subject with aggregation refusing mismatch. Block 27/27 on #7762 final + #7767; land release one-shot recipe in ci_layer_roots exclusion note. Co-authored-by: Cursor <cursoragent@cursor.com> * Fix CI: drop unavailable trim import in frontier_probe_types. git_object_id_from_untagged_hex already trims plumbing stdout; the frontier_survey_git_stdout_line wrapper imported trim from v2.std.text where it does not exist. Co-authored-by: Cursor <cursoragent@cursor.com> * Document four-PR chain and provenance hole requirements (#7763). Operator ruling: last of #7776 → #7762 → #7767 → survey; three provenance holes remain open; every shard must carry complete FrontierSurveySubject with all 27 comparing exactly equal. Co-authored-by: Cursor <cursoragent@cursor.com> * WIP: Lane 1: exact-current-head 27/27 frontier survey + status vocabulary cor * Close survey provenance findings 1–3 from operator review msg_e0b0c3ff. Carry probe_policy_revision on every TSV row and emit the measured literal in manifests; refuse dirty-worktree builds via BUILD_DIRTY; validate policy revision as structural ContentHash instead of tautological constant compare; document seed-only per-row subject enforcement on the carrier. Co-authored-by: Cursor <cursoragent@cursor.com> * Fix parse error in frontier_survey_probe_policy_revision_holds. Variant patterns bind positionally (Fnv1a64(structural)), not with typed field labels — the Colon form caused regen and heal_generated_artifacts to panic. Co-authored-by: Cursor <cursoragent@cursor.com> * WIP: Lane 1: exact-current-head 27/27 frontier survey + status vocabulary cor * Fix ProbeReceiptRow detail field after main merge. TSV loader rows default to FrontierProbeDetailAbsent to match main's receipt shape; fmt import order. Co-authored-by: Cursor <cursoragent@cursor.com> * Document CI non-enrollment for terminating long/ survey witnesses. Per-PR discovery omits src/v2/test/claim/long; offline local-recipe RED on stub manifest is not a CI failure shape. Co-authored-by: Cursor <cursoragent@cursor.com> * Fix policy-revision oracle and align transport source roots. Compare manifest probe_policy_revision against frontier_probe_policy_revision() instead of reusing the source-roots digest shape check. Add --source-root dag to survey_manifest_emit_args so the transport one-shot matches the shell recipe. Co-authored-by: Cursor <cursoragent@cursor.com> * Drop unused content_hash imports after policy-revision fix. Co-authored-by: Cursor <cursoragent@cursor.com> * Remove stale NFR row after policy-revision check rewrite. frontier_survey_probe_policy_revision_holds no longer wildcard-matches a coproduct parameter after switching to compare_content_hash; the roster row made non_fold_residue_stale_roster_count nonzero on CI. Co-authored-by: Cursor <cursoragent@cursor.com> * Address review 48957 scaffold notes and build stamp freshness. Mark Rust digest helpers as seed duplicates with emit dissolve triggers, rerun build.rs when survey bin sources change, and document src/v2-only versus dag+src/v2 source-root non-combinability at 9f978aa. Co-authored-by: Cursor <cursoragent@cursor.com> * Fix survey script failure guard to compare the failures variable. Use [[ failures -ne 0 ]] so probe failures refuse manifest promotion. Co-authored-by: Cursor <cursoragent@cursor.com> * Docs: predecessors merged; authoritative survey still on operator hold. Refresh closeout, provenance-holes, and offline-recipe notes after #7776, Co-authored-by: Cursor <cursoragent@cursor.com> #7762, and #7767 landed; document OOM-shell TSV projection limits post-#7767. --------- Co-authored-by: Brian Searls <briansearls1@gmail.com> Co-authored-by: Cursor <cursoragent@cursor.com>
…et-interrupted identities in place. Review 63330 is right that the rename was the #7762 discharge long_lane_exclusion_note forbids. The floor-cost-debt roster is the counted in-place withhold for the 500ms interrupt (run 34531151284). Co-authored-by: Cursor <cursoragent@cursor.com>
…acter (#10969) * Admit raw newlines in v2 string lexemes and cover the unmatched character. StringTextChar excluded LF, so a dag literal that v1 already accepts refused as tokenize_lex_e1_unrecognized_char, and the refusal locus was a zero-width caret before the offending character. Co-authored-by: Cursor <cursoragent@cursor.com> * Put the raw-newline admission on dag_string_literal_lex_rule, not StringTextChar. v1 scan_string_body never closes on LF; other language models that reuse StringTextChar still must. The unrecognized-char locus covers the opening quote of an unterminated literal. Co-authored-by: Cursor <cursoragent@cursor.com> * Hoist the unrecognized-char locus note above lex_walk_artifact. Section 4c only models module-item leading // blocks; the three in-body lines refused emit. Co-authored-by: Cursor <cursoragent@cursor.com> * Take native_decl_selection off the required floor: each claim is budget-refused at 500ms CPU. CI run 34531151284 interrupted all four identities before a verdict; the long-home prefix is the existing lane for that cost shape. Co-authored-by: Cursor <cursoragent@cursor.com> * Undo the native_decl_selection long-home move; withhold the four budget-interrupted identities in place. Review 63330 is right that the rename was the #7762 discharge long_lane_exclusion_note forbids. The floor-cost-debt roster is the counted in-place withhold for the 500ms interrupt (run 34531151284). Co-authored-by: Cursor <cursoragent@cursor.com> * Drop the native_decl_selection cost-debt withhold: #10992 already shares the fixture on this head. review 63512: ea674a6 is an ancestor; the roster must shrink, not keep coverage gone for a cause that no longer exists. Co-authored-by: Cursor <cursoragent@cursor.com> * Rename the string-literal probe helper so it does not collide with languages.dag dag_lex. Floor strict-prep refused: declaration_structure_preserved_test's dag_lex() became ambiguous after main added v2.extdeps.languages.dag.dag_lex into the same required-gate subject. Co-authored-by: Cursor <cursoragent@cursor.com> --------- Co-authored-by: gunbc-ci-auto-heal <gunbc-ci-auto-heal@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com> Co-authored-by: Brian Searls <11205878+briansrls@users.noreply.github.com>
Summary
Lane 3: large import closures ingest via typed
SourceRefread-through with closed population identity (FrontierProbeDiscoveredClosuresealed byfrontier_probe_discovered_closure_seal; host manifest binds digest before probe), storage-identity uniqueness, single-readSourceRefReadResult, structuralModuleRootLookup, andDiscoveredSourceRefsDigestcoproduct (no fabricated constants).Closed subject is closed: refs and
population_digestare sealed together — not separate caller inputs.frontier_probe_discovered_closure_subject_from_host_manifestrefuses when host digest disagrees with the sealed closure.Witness placement by purpose (operator msg_fca587a5)
Per-PR fast mechanism controls (
SubstrateInputsOnly, synthetic fixtures)File:
src/v2/test/claim/workflow/frontier_probe_closure_matrix_test.dagfrontier_probe_closure_storage_duplicate_refused_holdsfrontier_probe_closure_entry_binding_refused_holdsfrontier_probe_closure_count_mismatch_refused_holdsfrontier_probe_closure_refs_digest_mismatch_refused_holdsfrontier_probe_coverage_rows_missing_refused_holdsfrontier_probe_coverage_manifest_absent_refused_holdsfrontier_probe_elided_incomplete_refs_coverage_refused_holdsfrontier_probe_storage_hash_conflict_refused_holdsfrontier_probe_elided_cap_plus_one_coverage_gate_permitted_holdsExecuted receipt:
cargo build -p v1-compiler --bin claim_batchthenclaim_batch—target/frontier-probe-survey/matrix_gate_claim_batch_receipt.log— 9/9 PASS atfda56f0403(re-executed this fleet session).Scheduled boundary / integration controls (
ReadsLiveTree, wet)File:
src/v2/test/claim/long/frontier_probe_closure_matrix_integration_test.dagScheduled consumer:
FalsifierCadenceJob(commit_workflow.dagenrollment). Max staleness: one 4h cadence window.frontier_probe_read_failure_detail_refused_holdsfrontier_probe_hash_mismatch_detail_carries_observed_holdsfrontier_probe_ninety_one_read_compiler_closure_elision_integrates_holdsfrontier_probe_below_cap_complete_population_gates_pass_holdsfalsifier_rehomed_bin_wet_rowsfrontier_probe_second_source_root_population_gates_pass_holdsfalsifier_rehomed_bin_wet_rowsElision overlay recipe:
discover_source_root_ingest --entry src/v2/compiler/00_compile.dag --emit-dag-manifest target/frontier-probe-survey/overlay/host_source_root_ingest_manifest.dagthenclaim_batch --wet --source-root dag --source-root src/v2 --source-root target/frontier-probe-survey/overlay(overlay aftersrc/v2for stub supersede).Executed receipt:
target/frontier-probe-survey/matrix_integration_claim_batch_receipt.log— 3/3 PASS on cadence legs atfda56f0403(re-executed this fleet session). Full-pipeline legs enrolled onfalsifier_rehomed_bin_wet_rows(784772ms below_cap measured).Removed incoherent
elided_completepositive (read_count 2, cap 64). Cap+1 boundary is synthetic 65-read per-PR control.Frontier survey remeasure (
frontier_probe_survey, executed at HEAD)Binary:
cargo build -p v1-compiler --bin frontier_probe_survey. Receipt:target/frontier-probe-survey/head_survey_receipt.log, TSV:target/frontier-probe-survey/head_survey.tsv(executed this fleet session atfda56f0403).resolve_module_not_foundis not the reported blocker:00_compile.dagRealizationGap^parse_grammar_choice_overlap_residue03_ingest.dagRealizationGap^parse_grammar_choice_overlap_residuesource_authority.dagUnknownProbeCause^tokenize_lex_e1_unrecognized_charTest plan
claim_batch, receipt attarget/frontier-probe-survey/matrix_gate_claim_batch_receipt.log)claim_batch --wetwith overlay, receipt attarget/frontier-probe-survey/matrix_integration_claim_batch_receipt.log)head_survey.tsvat HEAD)falsifier_rehomed_bin_wet_rowswith measured costsci(pending after orphan-helper fix push)