Repository navigation
Conversation
Anchors the ~2s/entry setup diagnosis and binding P1–P4 order so selection honesty, width-2, and native expansion cannot outrun amortized prep. Co-authored-by: Cursor <cursoragent@cursor.com>
Address review 47719: P1 gates width and broad native enrollment only, not five-minute step 3's bounded cohort. Fold P3 conjunction (P1 + index share / Rc→Arc) with the measured width-latch receipts, and bank the claim_batch retain-all lower bound from the #7597 50-entry harness. Co-authored-by: Cursor <cursoragent@cursor.com>
P1 must discriminate on the armed floor A/B receipt. Additive harness shares are a different denominator, unarmed ≠ Mode B, and #7597 forbids mechanism selection from those prices. Co-authored-by: Cursor <cursoragent@cursor.com>
Every discovery completion now prints selection_state, selected/total entry groups, ratio, and fallback_reason so whole-corpus affected runs are counted degradations, not quiet success. Co-authored-by: Cursor <cursoragent@cursor.com>
…x source Fixed 50-entry cohort run through the real floor path (run_discovery_corpus_with_options, Adaptive width) in two modes: A (production eviction on) and B (GUNBC_SCHEDULE_RETENTION_EVICT=0, retain-all pole). Entries 2..34 (Mode B OOM-killed at 34/50 after unbounded RSS growth, honestly reported and not backfilled) show statistically indistinguishable wall/resolve times between modes — disabling schedule-retention eviction does not collapse the ~1-2s per-entry tax. Verdict: REJECT the retention hypothesis; redirect to assembly/materialization reuse, per the parent's stated criterion. Also fixes the cargo fmt violation from the prior P1 instrumentation commit that was failing CI on this PR. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Publish selection_state, counts, ratio, and fallback_reason on the measurement tail, resolve receipt, floor-component JSON, and dedicated receipt file so carrier-only emission cannot satisfy the P2 bar. Co-authored-by: Cursor <cursoragent@cursor.com>
…out. Resolve floor-prep-tax-program.md conflicts with P1 BANKED (REJECT) status, P2 LANDED status, and e2e closeout routing to assembly/materialization. Co-authored-by: Cursor <cursoragent@cursor.com>
Remove docs/plans/floor-prep-tax-program.md (owned by #7721). Add a discriminating test that skip-before-resolve rows do not inflate selected_entry_groups toward total. Co-authored-by: Cursor <cursoragent@cursor.com>
run_discovery_corpus_with_options already emits via emit_selection_degradation_receipt; remove the second DAG eval in run_discovery_batch_node (review 47735). Co-authored-by: Cursor <cursoragent@cursor.com>
…t field. Thread source_roots through write_resolve_receipt_at (pub(crate) default_source_roots is not visible from the bin target). Add missing selection_degradation on test ClaimResult. Co-authored-by: Cursor <cursoragent@cursor.com>
Keep integrated floor-prep-tax-program.md with P1 BANKED (REJECT) and P2 LANDED status. Co-authored-by: Cursor <cursoragent@cursor.com>
briansrls
marked this pull request as ready for review
August 3, 2026 04:06
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
Contributor
|
Closing — closeout must not open implementation PRs (same as #7726). This stacks #7721 program + #7725 P1 + #7722 P2. Those land on their own branches. Review 47776’s APPROVE and the non-blocking predicate-shape note apply to the P2 surface on #7722 ( — sent from still-moth-459 |
gunbai-bot Bot
pushed a commit
that referenced
this pull request
Aug 3, 2026
Co-authored-by: Cursor <cursoragent@cursor.com>
briansrls
pushed a commit
that referenced
this pull request
Aug 3, 2026
* docs: register floor prep-tax program (retention-first CI wall) Anchors the ~2s/entry setup diagnosis and binding P1–P4 order so selection honesty, width-2, and native expansion cannot outrun amortized prep. Co-authored-by: Cursor <cursoragent@cursor.com> * docs: clarify prep-tax gates vs five-minute native cutover Address review 47719: P1 gates width and broad native enrollment only, not five-minute step 3's bounded cohort. Fold P3 conjunction (P1 + index share / Rc→Arc) with the measured width-latch receipts, and bank the claim_batch retain-all lower bound from the #7597 50-entry harness. Co-authored-by: Cursor <cursoragent@cursor.com> * docs: retract #7597 Mode-B prior from prep-tax P1 framing P1 must discriminate on the armed floor A/B receipt. Additive harness shares are a different denominator, unarmed ≠ Mode B, and #7597 forbids mechanism selection from those prices. Co-authored-by: Cursor <cursoragent@cursor.com> * fix(docs): bind floor-prep-tax-program in doc graph Unbound hand-authored plan was an orphan under doc_graph_has_no_orphan_docs and blocked #7721 CI; enroll HandAuthoredDocBind and link from five-minute. Co-authored-by: Cursor <cursoragent@cursor.com> * docs: park floor prep-tax program with pickup snapshot Record P1 REJECT / open PR heads / HOLD leaves and ordered resume steps before operator pause; no further dispatch this stretch. Co-authored-by: Cursor <cursoragent@cursor.com> * docs: note closeout #7731 closed in park snapshot Co-authored-by: Cursor <cursoragent@cursor.com> * fix(docs): drop dangling P1 receipt link until #7725 merges doc_graph_has_no_dangling_links reds a relative link to a file that exists only on the P1 branch; cite the path/PR in prose instead. Co-authored-by: Cursor <cursoragent@cursor.com> * docs: correct #7725 CI block — main E0061, not leaf Co-authored-by: Cursor <cursoragent@cursor.com> * fix: restore 9-arg clone-bound call (main tip E0061) Same three-arg restore as #7734 — main's merge-ref fails the build gate on a stale 6-arg site. Temporary carry until #7733/#7734 land on main; dissolves when main is green. Co-authored-by: Cursor <cursoragent@cursor.com> * fix: align stage0 emit_rust with main after #7733 Regen failed: seed lagged the restored emitter (#7708 via #7733). Drop the temporary 3-line E0061 carry in favor of main's fixed-point seed. Co-authored-by: Cursor <cursoragent@cursor.com> * docs: bank P1 REJECT on #7725 in park snapshot Co-authored-by: Cursor <cursoragent@cursor.com> * docs: mark #7722 P2 merge-ready in park snapshot Co-authored-by: Cursor <cursoragent@cursor.com> --------- Co-authored-by: gunbc-ci-auto-heal <gunbc-ci-auto-heal@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto-opened by session-dashboard for session
warm-lynx-428.Pushing to
session/warm-lynx-428advances this PR.Worker attestation
Before flipping this PR to ready for review, confirm each item:
npm test,cargo test) and the result.Closes #Ndirective.Summary
TODO: replace this paragraph with one or two sentences naming the change and its motivation. Reviewers read this first.
Test plan